Package: keytouch-editor
Version: 1:3.2.0~beta-3
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
gcc -Wall -g -D_GNU_SOURCE -O2 -Wall -Wall -g -D_GNU_SOURCE -O2 -Wl,--as-needed 
-o keytouch-editor-bin  main.o support.o interface.o callbacks.o memory.o 
set_data.o error.o evdev.o get_scancode.o key_list.o keycodes.o plugins.o 
config.o email.o default_key_settings.o check_syntax.o acpi.o ud_socket.o 
../mxml/libmxml.a ../string_to_keycode/string_to_keycode.o -lgtk-x11-2.0 
-lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 
-lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype   

error: conflicting function declarations "read_keyboard_file"
old definition in module callbacks file ./keytouch-editor.h line 216
signed int (KTKeyList *, char **, char **, signed int *, signed int *, char *)
new definition in module config file config.c line 381
char (KTKeyList *key_list, char **manufacturer, char **model, signed int 
*usb_vendor_id, signed int *usb_product_id, char *file_name)
Makefile:189: recipe for target 'keytouch-editor-bin' failed
make[3]: *** [keytouch-editor-bin] Error 64
make[3]: Leaving directory 
'/srv/jenkins-slave/workspace/sid-goto-cc-keytouch-editor/keytouch-editor-3.2.0~beta/src'
Makefile:163: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1

Really, the above is only one of the possibly many consequences (resulting in
undefined behaviour, as only one of the bytes of the expected int being returned
is initialised) of this mess of typedefs:

http://sources.debian.net/src/keytouch-editor/1:3.2.0~beta-3/src/email.h?hl=31#L31
http://sources.debian.net/src/keytouch-editor/1:3.2.0~beta-3/mxml/mxml.h?hl=38#L38
http://sources.debian.net/src/keytouch-editor/1:3.2.0~beta-3/src/keytouch-editor.h?hl=39#L39
http://sources.debian.net/src/keytouch-editor/1:3.2.0~beta-3/src/evdev.h?hl=43#L43

By majority vote, fixing the typedef in mxml.h might do the trick.

Best,
Michael

Attachment: pgpLq82JZYPzP.pgp
Description: PGP signature

Reply via email to