Package: koules Version: 1.4-20 Severity: wishlist Usertags: goto-cc During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder) the build failed with the following error. Please note that we use our research compiler tool-chain (using tools from the cbmc package), which permits extended reporting on type inconsistencies at link time.
[...] gcc -o xkoules -g -O2 -fno-strict-aliasing -Wl,-z,relro koules.o menu.o gameplan.o font.o intro.o rcfiles.o framebuffer.o cmap-x11.o sound.o nas_sound.o rsound.o client.o server.o sock.o objectsio.o mygetopt.o util/libutils.a xlib/libxlib.a -lXext -lX11 -lm error: conflicting types for variable "control" old definition in module koules file koules.c line 52 unsigned char [5l] new definition in module menu file koules.h line 240 char [5l] Makefile:1118: recipe for target 'xkoules' failed make[1]: *** [xkoules] Error 64 make[1]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-koules/koules-1.4' debian/rules:25: recipe for target 'build-arch-stamp' failed make: *** [build-arch-stamp] Error 2 Indeed it seems that control is just used as an array of Boolean values, thus undefined behaviour would not be expected at present. Nevertheless it seems worthwhile marking it as unsigned char uniformly to enable the compiler to generate appropriate diagnostics. Best, Michael
pgpqsw0uEV06C.pgp
Description: PGP signature