Package: libdc1394-22
Version: 2.2.2-1
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
libtool: link:  gcc -shared  -fPIC -DPIC  .libs/control.o .libs/enumeration.o 
.libs/capture.o .libs/format7.o .libs/register.o .libs/utils.o .libs/internal.o 
.libs/conversions.o .libs/bayer.o .libs/log.o .libs/iso.o  -Wl,--whole-archive 
linux/.libs/libdc1394-linux.a juju/.libs/libdc1394-juju.a 
usb/.libs/libdc1394-usb.a vendor/.libs/libdc1394-vendor.a 
-Wl,--no-whole-archive  /usr/lib/x86_64-linux-gnu/libraw1394.so -lpthread 
-lusb-1.0 -lm  -O2 -Wl,-z -Wl,relro   -Wl,-soname -Wl,libdc1394.so.22 
-Wl,-version-script -Wl,.libs/libdc1394.ver -o .libs/libdc1394.so.22.1.9

old definition in module utils file utils.c line 94
int (struct __dc1394_camera *camera, dc1394video_mode_t video_mode, unsigned 
int *w, unsigned int *h)
new definition in module internal file ../dc1394/utils.h line 41
int (struct __dc1394_camera *, unsigned int, unsigned int *, unsigned int *)
Makefile:517: recipe for target 'libdc1394.la' failed
make[5]: *** [libdc1394.la] Error 64
make[5]: Leaving directory 
'/srv/jenkins-slave/workspace/sid-goto-cc-libdc1394-22/libdc1394-22-2.2.2/dc1394'
Makefile:593: recipe for target 'all-recursive' failed

The above type conflict on parameter video_mode might just be a leftover of an
earlier refactoring: indeed the declaration here

http://sources.debian.net/src/libdc1394-22/2.2.2-1/dc1394/utils.h?hl=41#L41

should just be updated to match the definition at

http://sources.debian.net/src/libdc1394-22/2.2.2-1/dc1394/utils.c?hl=94#L94

as also other functions declared in utils.h use the dc1394video_mode_t enum
type.

This will ensure the compiler performs appropriate conversion or promotion,
which may differ from that towards an unsigned.

Best,
Michael

Attachment: pgpYYMA1OCGz3.pgp
Description: PGP signature

Reply via email to