tag 748832 patch -moreinfo user [email protected] tag 748832 autopkgtest thanks
Hey Jelmer, Jelmer Vernooij [2014-05-24 2:50 +0200]: > I can't reproduce this unless I run those commands from an unbuilt > source tree. Hm, I indeed just tried it again in schroot and it works now. So I suppose what happened was that I checked out the subvertpy source and as schroot keeps the current directory the import tried to import from the (unbuilt) source tree. So, sorry for the false alarm! > You stumbled upon the reason I added it - without building (in place, > not in dist/) first, they fail. > > Obviously this is a sign that we're testing the source tree binaries > rather than the installed binaries, which is not the intention of > debian/tests/. Then this is trivial to fix -- just avoid searching for the modules in the source tree. Tested patch attached (but there's certainly other ways to achieve the same). > I really like the idea of autopkgtest but it's still a pain to run > these tests locally. Do you have suggestions how to make it easier? In the simplest case you just need to run "debian/tests/testsuite", or with autopkgtest itself with e. g. adt-run -B .// --- null # on local machine adt-run -B subvertpy_0.9.1-5.dsc --- schroot sid # in "sid" schroot Due to historical/backwards compatible reasons this could certainly look a bit prettier, but it's certainly not rocket science? > For subvertpy we're just running the standard > testsuite - installed - that already runs as part of the build anyway, > so autopkgtest is just not worth the trouble at the moment for me. > I'll disable or remove the autopkgtests with the next upload. As you wish, but it's trivial to fix, and will immediately tell you when something in your dependencies or Python itself changes which breaks subvertpy (and once we integrate autopkgtest into britney it will even prevent that regression to land, as we already do in Ubuntu). Thanks, Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -Nru subvertpy-0.9.1/debian/changelog subvertpy-0.9.1/debian/changelog --- subvertpy-0.9.1/debian/changelog 2014-03-01 15:25:56.000000000 +0100 +++ subvertpy-0.9.1/debian/changelog 2014-05-24 08:42:26.000000000 +0200 @@ -1,3 +1,11 @@ +subvertpy (0.9.1-6) UNRELEASED; urgency=medium + + * autopkgtest: Use the system-installed modules and test suite instead of + the local source tree. Drop unnecessary "build-needed" restriction. + (Closes: #748832) + + -- Martin Pitt <[email protected]> Sat, 24 May 2014 08:41:15 +0200 + subvertpy (0.9.1-5) unstable; urgency=medium * Move autopkgtest restrictions to restrictions field. diff -Nru subvertpy-0.9.1/debian/tests/control subvertpy-0.9.1/debian/tests/control --- subvertpy-0.9.1/debian/tests/control 2014-03-01 15:17:48.000000000 +0100 +++ subvertpy-0.9.1/debian/tests/control 2014-05-24 08:40:28.000000000 +0200 @@ -1,3 +1,3 @@ Tests: testsuite Depends: python-subvertpy -Restrictions: allow-stderr build-needed +Restrictions: allow-stderr diff -Nru subvertpy-0.9.1/debian/tests/testsuite subvertpy-0.9.1/debian/tests/testsuite --- subvertpy-0.9.1/debian/tests/testsuite 2014-02-26 01:00:15.000000000 +0100 +++ subvertpy-0.9.1/debian/tests/testsuite 2014-05-24 08:41:05.000000000 +0200 @@ -1,3 +1,5 @@ #!/bin/sh set -e +# use the system installed modules, not the local source +cd debian/tests python -m unittest subvertpy.tests.test_suite
signature.asc
Description: Digital signature
