Package: linsmith Version: 0.99.21-1 Usertags: goto-cc During an analysis of all Debian packages using our research compiler tool-chain (using tools from the cbmc package) the following error was found:
recalculate_all takes one argument: http://sources.debian.net/src/linsmith/0.99.21-1/src/chart.c?hl=847#L847 Yet none is passed when called from here, necessarily leading to stack underflow and thus to undefined behaviour as an arbitrary value will be used: http://sources.debian.net/src/linsmith/0.99.21-1/src/misc.c?hl=640#L640 Note that this could easily have been avoided if compiler warnings had been obeyed: [...] x86_64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_DATA_DIR=\""/usr/share"\" -DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\" -D_REENTRANT -DORBIT2=1 -pthread -I/usr/include/libgnomeui-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libxml2 -I/usr/include/libgnome-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/orbit-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gail-1.0 -I/usr/include/libart-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/x86_64-linux-gnu/gnome-vfs-2.0/include -I/usr/include/gconf/2 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng12 -I/usr/include/libxml2 -Wall -g -O2 -Wl,-z,defs,--as-needed -MT misc.o -MD -MP -MF .deps/misc.Tpo -c -o misc.o misc.c [...] misc.c: In function 'on_comp_scale_value_changed': misc.c:640:3: warning: implicit declaration of function 'recalculate_all' [-Wimplicit-function-declaration] recalculate_all(); ^ Best, Michael
pgp6PRy5qpKBb.pgp
Description: PGP signature
