Package: json-schema-validator Version: 2.3.1-2 User: autopkgtest-de...@lists.alioth.debian.org Usertags: autopkgtest
Hello, thanks for adding an autopkgtest to json-schema-validator! However, it fails [1] because of Python unittest's unfortunate habit of writing all the test output to stderr by default. (It will also fail on http://ci.debian.net, but that hasn't picked it up yet). This can easily be rectified by adding "Restrictions: allow-stderr" to debian/tests/control, or by redirecting the test stderr to stdout with 2>&1. However, the deeper problem with that new test is that it runs tests against the build tree, not the installed package. The test does not even depend on python-json-schema-validator. So this achieves nothing to prove that the built python-json-schema-validator package is actually working. One way is to find an easy way to run the upstream test suite (from the source tree) against the installed package. A common trick is to copy just the tests directory to e. g. $ADTTMP and run it there, so that any $PYTHONPATH that the test suite may set will be rendered ineffective. If that turns out to be too hard, I suggest to just write a simple smoketest which imports the module and call a simple function from it. This proves that the package has the right contents, the dh_* magic worked, and there is no crash on import. The fine details on the inner workings can be left to running the upstream tests against the build tree during package build. Thanks for considering, Martin [1] https://jenkins.qa.ubuntu.com/job/utopic-adt-json-schema-validator/ARCH=amd64,label=adt/1/console -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
signature.asc
Description: Digital signature
