reassign 746965 igerman98 retitle 746965 igerman98: Please use recent debhelper snippets from dictionaries-common notfound 746965 dictionaries-common/1.23.2 found 746965 igerman98/20131206-2 thanks
On Mon, May 05, 2014 at 06:59:34PM +0200, Chris wrote: > Hi, > > and sorry again. Sometimes you should not post infos to bugreports when > having thousands of other things in mind. :-/ > > The infos above where wrong, i have seen the same issue on a debian > testing installation having the following packages installed: > > ispell 3.3.02-6 > ingerman 20131206-2 > dictionaries-common 1.23.2 > > Additional i'm also answering your questions: > > > Seems something went wrong with /var/lib/ispell contents. It should contain > > at least ngerman.compat. > > The directory in here is also empty and doesn't contain any files. Thanks for the info, seems I catched the reason for this. I guess you were uograding from 20120607-1 when this problem appeared. The problem is that ingerman and friends previously shipped files under /var/lib/{a,i}spell along with the package. They no longer do that and do not use the standard debhelper snippets from dictionaries-common. The result is that files under /var/lib/{a,i}spell are created in preinst, but they are removed during upgrade when unpacking, because they also belonged to old package, see http://anonscm.debian.org/gitweb/?p=dict-common/dictionaries-common.git;a=commitdiff;h=82f039ca84cc47a3914fdf42815fd0967a46407c for the details. debhelper snippets from dictionaries-common-dev work around this problem since above commit, but igerman98 maintainer scripts don't. I am reassignng this bug report to igerman98 and proposing a couple of patches. One is to fully use debhelper snippets from dictionaries-common-dev and also deal with current piuparts failure. The other is too stop using ancient /usr/share/myspell dirs. Proposed changelog entries: * Update to use standard debhelper snippets from dictionaries-common-dev to better handle upgrades from old versions (Closes: #746965). * No longer ship anything under ancient /usr/share/myspell Resulting packages are minimally tested, so Roland please test a bit more if you use those patches. R$egards, -- Agustin
>From 91ad2e9bad93aa5e26f484d6baf3d78d0eca7628 Mon Sep 17 00:00:00 2001 From: Agustin Martin Domingo <agmar...@debian.org> Date: Tue, 6 May 2014 12:54:05 +0200 Subject: [PATCH 1/2] Use standard DC debhelper snippets to better handle upgrades from old versions (Closes: #746965). Current maintainer scripts can cause problems with old packages that owned dummy compat and hash files http://anonscm.debian.org/gitweb/?p=dict-common/dictionaries-common.git;a=commitdiff;h=82f039ca84cc47a3914fdf42815fd0967a46407c Make sure compat file is recreated from postinst if not available. Use dictionaries-common-dev 1.21 substvars. --- debian/aspell-de.dirs | 2 -- debian/aspell-de.info-aspell | 2 ++ debian/aspell-de.links | 4 ---- debian/aspell-de.postinst | 3 --- debian/aspell-de.postrm | 13 ------------- debian/control | 12 ++++++------ debian/ingerman.config.in | 11 ----------- debian/ingerman.dirs | 1 - debian/ingerman.info-ispell | 1 + debian/ingerman.preinst | 5 ----- debian/iswiss.config.in | 11 ----------- debian/iswiss.dirs | 1 - debian/iswiss.info-ispell | 1 + debian/iswiss.preinst | 5 ----- debian/rules | 18 +++++------------- 15 files changed, 15 insertions(+), 75 deletions(-) delete mode 100644 debian/aspell-de.links delete mode 100644 debian/ingerman.config.in delete mode 100644 debian/iswiss.config.in diff --git a/debian/aspell-de.dirs b/debian/aspell-de.dirs index f7ced23..3bf2692 100644 --- a/debian/aspell-de.dirs +++ b/debian/aspell-de.dirs @@ -1,4 +1,2 @@ usr/lib/aspell usr/share/aspell -var/lib/aspell -var/lib/dictionaries-common/aspell diff --git a/debian/aspell-de.info-aspell b/debian/aspell-de.info-aspell index 5650e6a..1ea4e08 100644 --- a/debian/aspell-de.info-aspell +++ b/debian/aspell-de.info-aspell @@ -6,6 +6,8 @@ Not-Casechars: [^A-Za-z Additionalchars: ΔάΦδόφί Coding-System: iso-8859-1 Aspell-Locales: de +Auto-Compat: de +Auto-Contents: de Language: deutsch/Deutschland (German/Germany) Hash-Name: de_DE diff --git a/debian/aspell-de.links b/debian/aspell-de.links deleted file mode 100644 index e487a31..0000000 --- a/debian/aspell-de.links +++ /dev/null @@ -1,4 +0,0 @@ -var/lib/aspell/de-common.rws usr/lib/aspell/de-common.rws -var/lib/aspell/de_AT-only.rws usr/lib/aspell/de_AT-only.rws -var/lib/aspell/de_CH-only.rws usr/lib/aspell/de_CH-only.rws -var/lib/aspell/de_DE-only.rws usr/lib/aspell/de_DE-only.rws diff --git a/debian/aspell-de.postinst b/debian/aspell-de.postinst index 21706ef..e487876 100644 --- a/debian/aspell-de.postinst +++ b/debian/aspell-de.postinst @@ -22,9 +22,6 @@ case "$1" in --slave $DIR/de_AT.multi de_AT.multi $DIR/de_AT-neu.multi \ --slave $DIR/de_CH.multi de_CH.multi $DIR/de_CH-neu.multi \ --slave $DIR/de_DE.multi de_DE.multi $DIR/de_DE-neu.multi - - # register with installdeb-aspell - touch /var/lib/aspell/de.compat ;; abort-upgrade|abort-remove|abort-deconfigure) diff --git a/debian/aspell-de.postrm b/debian/aspell-de.postrm index 6a135f8..3ebf6d7 100644 --- a/debian/aspell-de.postrm +++ b/debian/aspell-de.postrm @@ -17,19 +17,6 @@ set -e # for details, see http://www.debian.org/doc/debian-policy/ or # the debian-policy package -case "$1" in - purge|remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear) - rm -f /var/lib/aspell/de.compat - # remove generated files since update-dictcommon-aspell does not - rm -f /var/lib/aspell/de-common.rws /var/lib/aspell/de_AT-only.rws /var/lib/aspell/de_CH-only.rws /var/lib/aspell/de_DE-only.rws - ;; - - *) - echo "postrm called with unknown argument \`$1'" >&2 - exit 1 - ;; -esac - # dh_installdeb will replace this with shell code automatically # generated by other debhelper scripts. diff --git a/debian/control b/debian/control index 76f6c99..acb597b 100644 --- a/debian/control +++ b/debian/control @@ -5,14 +5,14 @@ Maintainer: Roland Rosenfeld <rol...@debian.org> Uploaders: Rene Engelhard <r...@debian.org> Standards-Version: 3.9.5 Build-Depends-Indep: ispell (>= 3.1.20-12.1), hunspell, aspell (>= 0.60.5-2), - dictionaries-common-dev (>= 1.10.5) + dictionaries-common-dev (>= 1.23.2) Build-Depends: debhelper (>= 9) Homepage: https://www.j3e.de/ispell/igerman98/ Package: ingerman Architecture: all Provides: ispell-dictionary -Depends: ${misc:Depends}, ispell, dictionaries-common (>= 0.20.0) +Depends: ${misc:Depends}, ${ispell:Depends} Suggests: wngerman Description: New German orthography dictionary for ispell This is a dictionary for ispell for the new German orthography @@ -26,7 +26,7 @@ Description: New German orthography dictionary for ispell Package: iswiss Architecture: all Provides: ispell-dictionary -Depends: ${misc:Depends}, ispell, dictionaries-common (>= 0.20.0) +Depends: ${misc:Depends}, ${ispell:Depends} Suggests: wswiss Description: Swiss (German) orthography dictionary for ispell This is a dictionary for ispell for the new German orthography @@ -43,7 +43,7 @@ Description: Swiss (German) orthography dictionary for ispell Package: wngerman Architecture: all Provides: wordlist -Depends: ${misc:Depends}, dictionaries-common (>= 0.20.0) +Depends: ${misc:Depends}, ${wordlist:Depends} Description: New German orthography wordlist This is a wordlist with the new German orthography (de-DE-1996), which is used since 1998-08-01 and which is obligatory as of @@ -56,7 +56,7 @@ Description: New German orthography wordlist Package: wswiss Architecture: all Provides: wordlist -Depends: ${misc:Depends}, dictionaries-common (>= 0.20.0) +Depends: ${misc:Depends}, ${wordlist:Depends} Description: Swiss (German) orthography wordlist This is a wordlist with the new German orthography (de-CH-1996), which is used since 1998-08-01 and which is obligatory as of 2005-08-01. @@ -175,7 +175,7 @@ Description: German dictionary for hunspell Package: aspell-de Architecture: all -Depends: aspell (>= 0.60.5-2), dictionaries-common (>= 0.9.1), ${misc:Depends} +Depends: ${misc:Depends}, ${aspell:Depends} Provides: aspell-dictionary Description: German dictionary for aspell This package contains German dictionaries for the aspell spell checker. diff --git a/debian/ingerman.config.in b/debian/ingerman.config.in deleted file mode 100644 index 5ad92c8..0000000 --- a/debian/ingerman.config.in +++ /dev/null @@ -1,11 +0,0 @@ -#!/usr/bin/perl -w - -#DEBHELPER# - -if ( $ARGV[0] eq "reconfigure" ){ - my $flag_file = "/var/lib/ispell/ngerman.compat"; - open (REC_FLAG,"> $flag_file") - or die "Could not open $flag_file for writing\n"; - print REC_FLAG "0"; - close REC_FLAG; -} diff --git a/debian/ingerman.dirs b/debian/ingerman.dirs index f408d15..da3e073 100644 --- a/debian/ingerman.dirs +++ b/debian/ingerman.dirs @@ -1,3 +1,2 @@ /usr/lib/ispell -/var/lib/ispell /usr/share/ispell diff --git a/debian/ingerman.info-ispell b/debian/ingerman.info-ispell index 96a5063..0082e67 100644 --- a/debian/ingerman.info-ispell +++ b/debian/ingerman.info-ispell @@ -23,3 +23,4 @@ Ispell-Args: -C -d ngerman Extended-Character-Mode: ~latin1 Coding-System: iso-8859-1 Locale: de_DE +Auto-Compat: ngerman diff --git a/debian/ingerman.preinst b/debian/ingerman.preinst index c466d1d..3d706bd 100644 --- a/debian/ingerman.preinst +++ b/debian/ingerman.preinst @@ -9,9 +9,4 @@ if [ -f "${bogus_compat}" ] ; then rm "${bogus_compat}" fi -# create empty compat|hash files: -[ -d /var/lib/ispell ] || mkdir -p /var/lib/ispell -echo "" > /var/lib/ispell/ngerman.compat -touch /var/lib/ispell/ngerman.hash - #DEBHELPER# diff --git a/debian/iswiss.config.in b/debian/iswiss.config.in deleted file mode 100644 index c3281cb..0000000 --- a/debian/iswiss.config.in +++ /dev/null @@ -1,11 +0,0 @@ -#!/usr/bin/perl -w - -#DEBHELPER# - -if ( $ARGV[0] eq "reconfigure" ){ - my $flag_file = "/var/lib/ispell/swiss.compat"; - open (REC_FLAG,"> $flag_file") - or die "Could not open $flag_file for writing\n"; - print REC_FLAG "0"; - close REC_FLAG; -} diff --git a/debian/iswiss.dirs b/debian/iswiss.dirs index f408d15..da3e073 100644 --- a/debian/iswiss.dirs +++ b/debian/iswiss.dirs @@ -1,3 +1,2 @@ /usr/lib/ispell -/var/lib/ispell /usr/share/ispell diff --git a/debian/iswiss.info-ispell b/debian/iswiss.info-ispell index d3dc279..51a1cf4 100644 --- a/debian/iswiss.info-ispell +++ b/debian/iswiss.info-ispell @@ -23,3 +23,4 @@ Ispell-Args: -C -d swiss Extended-Character-Mode: ~latin1 Coding-System: iso-8859-1 Locale: de_CH +Auto-Compat: swiss diff --git a/debian/iswiss.preinst b/debian/iswiss.preinst index 4409943..1fb985b 100644 --- a/debian/iswiss.preinst +++ b/debian/iswiss.preinst @@ -9,9 +9,4 @@ if [ -f "${bogus_compat}" ] ; then rm "${bogus_compat}" fi -# create empty compat|hash files: -[ -d /var/lib/ispell ] || mkdir -p /var/lib/ispell -echo "" > /var/lib/ispell/swiss.compat -touch /var/lib/ispell/swiss.hash - #DEBHELPER# diff --git a/debian/rules b/debian/rules index ca2080e..cdb3474 100755 --- a/debian/rules +++ b/debian/rules @@ -1,11 +1,11 @@ #!/usr/bin/make -f # # (C) 1999-2009 Roland Rosenfeld <rol...@debian.org>, based on -# Sample debian/rules that uses debhelper. +# Sample debian/rules that uses debhelper. # This file is public domain software, originally written by Joey Hess. # -# Uncomment this to turn on verbose mode. +# Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 DROOT=`pwd`/debian @@ -48,7 +48,7 @@ clean: clean1 clean1: dh_testdir dh_testroot - rm -f build-stamp + rm -f build-stamp $(MAKE) clean rm -f debian/ingerman.config debian/ingerman.templates @@ -77,10 +77,6 @@ install: build $(DROOT)/ingerman/usr/lib/ispell/ngerman.aff gzip -9 < all.words.munch.de_DE.tmp \ > $(DROOT)/ingerman/usr/share/ispell/ngerman.mwl.gz - #touch $(DROOT)/ingerman/var/lib/ispell/ngerman.compat - #touch $(DROOT)/ingerman/var/lib/ispell/ngerman.hash - (cd $(DROOT)/ingerman/usr/lib/ispell; \ - ln -s "../../../var/lib/ispell/ngerman.hash" ngerman.hash) (cd $(DROOT)/ingerman/usr/lib/ispell; \ ln -s ngerman.aff ndeutsch.aff; \ ln -s ngerman.hash ndeutsch.hash;) @@ -90,10 +86,6 @@ install: build $(DROOT)/iswiss/usr/lib/ispell/swiss.aff gzip -9 < all.words.munch.de_CH.tmp \ > $(DROOT)/iswiss/usr/share/ispell/swiss.mwl.gz - #touch $(DROOT)/iswiss/var/lib/ispell/swiss.compat - #touch $(DROOT)/iswiss/var/lib/ispell/swiss.hash - (cd $(DROOT)/iswiss/usr/lib/ispell; \ - ln -s "../../../var/lib/ispell/swiss.hash" swiss.hash) (cd $(DROOT)/iswiss/usr/lib/ispell; \ ln -s swiss.aff deutsch-schweiz.aff; \ ln -s swiss.hash deutsch-schweiz.hash;) @@ -102,7 +94,7 @@ install: build iconv -f iso-8859-1 -t utf-8 < isowordlist-de_DE \ > $(DROOT)/wngerman/usr/share/dict/ngerman -# wswiss (binary-indep): +# wswiss (binary-indep): iconv -f iso-8859-1 -t utf-8 < isowordlist-de_CH \ > $(DROOT)/wswiss/usr/share/dict/swiss @@ -298,7 +290,7 @@ binary-indep: build install dh_md5sums -i -Xvar/lib/ispell -Xvar/lib/aspell dh_builddeb -i -binary-arch: +binary-arch: # does nothing, because the package is Architecture: all binary: binary-indep binary-arch -- 2.0.0.rc0
>From 7e17c818d288480c8fb6d6c98c5e2e2a37e2cf82 Mon Sep 17 00:00:00 2001 From: Agustin Martin Domingo <agmar...@debian.org> Date: Tue, 6 May 2014 13:02:00 +0200 Subject: [PATCH 2/2] No longer ship anything under ancient /usr/share/myspell --- debian/hunspell-de-at.dirs | 1 - debian/hunspell-de-ch.dirs | 1 - debian/hunspell-de-de.dirs | 1 - debian/myspell-de-at.dirs | 1 - debian/myspell-de-ch.dirs | 1 - debian/myspell-de-de.dirs | 1 - debian/rules | 54 ---------------------------------------------- 7 files changed, 60 deletions(-) diff --git a/debian/hunspell-de-at.dirs b/debian/hunspell-de-at.dirs index 826d9ee..64b8f86 100644 --- a/debian/hunspell-de-at.dirs +++ b/debian/hunspell-de-at.dirs @@ -1,2 +1 @@ usr/share/hunspell -usr/share/myspell/dicts diff --git a/debian/hunspell-de-ch.dirs b/debian/hunspell-de-ch.dirs index 826d9ee..64b8f86 100644 --- a/debian/hunspell-de-ch.dirs +++ b/debian/hunspell-de-ch.dirs @@ -1,2 +1 @@ usr/share/hunspell -usr/share/myspell/dicts diff --git a/debian/hunspell-de-de.dirs b/debian/hunspell-de-de.dirs index 826d9ee..64b8f86 100644 --- a/debian/hunspell-de-de.dirs +++ b/debian/hunspell-de-de.dirs @@ -1,2 +1 @@ usr/share/hunspell -usr/share/myspell/dicts diff --git a/debian/myspell-de-at.dirs b/debian/myspell-de-at.dirs index 826d9ee..64b8f86 100644 --- a/debian/myspell-de-at.dirs +++ b/debian/myspell-de-at.dirs @@ -1,2 +1 @@ usr/share/hunspell -usr/share/myspell/dicts diff --git a/debian/myspell-de-ch.dirs b/debian/myspell-de-ch.dirs index 826d9ee..64b8f86 100644 --- a/debian/myspell-de-ch.dirs +++ b/debian/myspell-de-ch.dirs @@ -1,2 +1 @@ usr/share/hunspell -usr/share/myspell/dicts diff --git a/debian/myspell-de-de.dirs b/debian/myspell-de-de.dirs index 826d9ee..64b8f86 100644 --- a/debian/myspell-de-de.dirs +++ b/debian/myspell-de-de.dirs @@ -1,2 +1 @@ usr/share/hunspell -usr/share/myspell/dicts diff --git a/debian/rules b/debian/rules index cdb3474..6048a69 100755 --- a/debian/rules +++ b/debian/rules @@ -114,15 +114,6 @@ install: build (cd $(DROOT)/myspell-de-ch/usr/share/hunspell; \ ln -s de_CH.aff de_LI.aff; \ ln -s de_CH.dic de_LI.dic) - (cd $(DROOT)/myspell-de-ch/usr/share/myspell/dicts; \ - ln -s ../../hunspell/de_CH.aff de_CH.aff; \ - ln -s ../../hunspell/de_CH.dic de_CH.dic; \ - ln -s ../../hunspell/de_LI.aff de_LI.aff; \ - ln -s ../../hunspell/de_LI.dic de_LI.dic; \ - ln -s ../../hunspell/de_CH.aff de-CH.aff; \ - ln -s ../../hunspell/de_CH.dic de-CH.dic; \ - ln -s ../../hunspell/de_LI.aff de-LI.aff; \ - ln -s ../../hunspell/de_LI.dic de-LI.dic) # myspell-de-de (binary-indep) install -o root -g root -m644 myspell/de_DE.aff \ @@ -134,30 +125,12 @@ install: build ln -s de_DE.dic de_BE.dic; \ ln -s de_DE.aff de_LU.aff; \ ln -s de_DE.dic de_LU.dic) - (cd $(DROOT)/myspell-de-de/usr/share/myspell/dicts; \ - ln -s ../../hunspell/de_DE.aff de_DE.aff; \ - ln -s ../../hunspell/de_DE.dic de_DE.dic; \ - ln -s ../../hunspell/de_BE.aff de_BE.aff; \ - ln -s ../../hunspell/de_BE.dic de_BE.dic; \ - ln -s ../../hunspell/de_LU.aff de_LU.aff; \ - ln -s ../../hunspell/de_LU.dic de_LU.dic; \ - ln -s ../../hunspell/de_DE.aff de-DE.aff; \ - ln -s ../../hunspell/de_DE.dic de-DE.dic; \ - ln -s ../../hunspell/de_BE.aff de-BE.aff; \ - ln -s ../../hunspell/de_BE.dic de-BE.dic; \ - ln -s ../../hunspell/de_LU.aff de-LU.aff; \ - ln -s ../../hunspell/de_LU.dic de-LU.dic) # myspell-de-at (binary-indep) install -o root -g root -m644 myspell/de_AT.aff \ $(DROOT)/myspell-de-at/usr/share/hunspell install -o root -g root -m644 myspell/de_AT.dic \ $(DROOT)/myspell-de-at/usr/share/hunspell - (cd $(DROOT)/myspell-de-at/usr/share/myspell/dicts; \ - ln -s ../../hunspell/de_AT.dic de_AT.dic; \ - ln -s ../../hunspell/de_AT.aff de_AT.aff; \ - ln -s ../../hunspell/de_AT.dic de-AT.dic; \ - ln -s ../../hunspell/de_AT.aff de-AT.aff) # hunspell-de-ch (binary-indep) install -o root -g root -m644 hunspell/de_CH.aff \ @@ -167,15 +140,6 @@ install: build (cd $(DROOT)/hunspell-de-ch/usr/share/hunspell; \ ln -s de_CH.aff de_LI.aff; \ ln -s de_CH.dic de_LI.dic) - (cd $(DROOT)/hunspell-de-ch/usr/share/myspell/dicts; \ - ln -s ../../hunspell/de_CH.aff de_CH.aff; \ - ln -s ../../hunspell/de_CH.dic de_CH.dic; \ - ln -s ../../hunspell/de_LI.aff de_LI.aff; \ - ln -s ../../hunspell/de_LI.dic de_LI.dic; \ - ln -s ../../hunspell/de_CH.aff de-CH.aff; \ - ln -s ../../hunspell/de_CH.dic de-CH.dic; \ - ln -s ../../hunspell/de_LI.aff de-LI.aff; \ - ln -s ../../hunspell/de_LI.dic de-LI.dic) # hunspell-de-de (binary-indep) install -o root -g root -m644 hunspell/de_DE.aff \ @@ -187,30 +151,12 @@ install: build ln -s de_DE.dic de_BE.dic; \ ln -s de_DE.aff de_LU.aff; \ ln -s de_DE.aff de_LU.dic) - (cd $(DROOT)/hunspell-de-de/usr/share/myspell/dicts; \ - ln -s ../../hunspell/de_DE.aff de_DE.aff; \ - ln -s ../../hunspell/de_DE.dic de_DE.dic; \ - ln -s ../../hunspell/de_BE.aff de_BE.aff; \ - ln -s ../../hunspell/de_BE.dic de_BE.dic; \ - ln -s ../../hunspell/de_LU.aff de_LU.aff; \ - ln -s ../../hunspell/de_LU.dic de_LU.dic; \ - ln -s ../../hunspell/de_DE.aff de-DE.aff; \ - ln -s ../../hunspell/de_DE.dic de-DE.dic; \ - ln -s ../../hunspell/de_BE.aff de-BE.aff; \ - ln -s ../../hunspell/de_BE.dic de-BE.dic; \ - ln -s ../../hunspell/de_LU.aff de-LU.aff; \ - ln -s ../../hunspell/de_LU.dic de-LU.dic) # hunspell-de-at (binary-indep) install -o root -g root -m644 hunspell/de_AT.aff \ $(DROOT)/hunspell-de-at/usr/share/hunspell install -o root -g root -m644 hunspell/de_AT.dic \ $(DROOT)/hunspell-de-at/usr/share/hunspell - (cd $(DROOT)/hunspell-de-at/usr/share/myspell/dicts; \ - ln -s ../../hunspell/de_AT.dic de_AT.dic; \ - ln -s ../../hunspell/de_AT.aff de_AT.aff; \ - ln -s ../../hunspell/de_AT.dic de-AT.dic; \ - ln -s ../../hunspell/de_AT.aff de-AT.aff) # aspell-de (binary-indep) install -o root -g root -m644 aspell/de_DE.multi \ -- 2.0.0.rc0