Hi,

Yes, with a few edits, I've been able to merge your patch into master.

Thanks!

Mathieu

----- Original Message -----
> From: "Helge Deller" <del...@gmx.de>
> To: "Mathieu Desnoyers" <mathieu.desnoy...@efficios.com>
> Cc: 742...@bugs.debian.org
> Sent: Wednesday, April 2, 2014 5:02:33 PM
> Subject: Re: [lttng-dev] Bug#742979: liburcu FTBFS on hppa architecture - 
> patches attached
> 
> * Mathieu Desnoyers <mathieu.desnoy...@efficios.com>:
> > Could you add a changelog (with title and patch
> > description) ending with a
> > Signed-off-by: Name Lastname <email>
> > 
> > at the top of each patch to follow our certificate of
> > origin tracking ? See
> > http://elinux.org/Developer_Certificate_Of_Origin
> > 
> > Also, there is an extra space here:
> > 
> >   asm volatile( "mfctl 16, %0" : "=r" (cycles));
> > 
> > should be changed to:
> > 
> >   asm volatile("mfctl 16, %0" : "=r" (cycles));
> > 
> > Thanks,
> > 
> > Mathieu
> 
> Thanks Mathieu!
> 
> Here it is. I hope it's OK ?
> 
> Helge
> 
> [PATCH] Add support for hppa/PA-RISC architecture
> 
> Add the missing architecture specific functions to provide support for the
> hppa/PA-RISC architecture:
> - the processor internal time stamp counter (Control Register CR16) is used
> to
>   get high-performance/low-latency cycle counts
> - gcc provides the necessary built-in atomic functions on hppa (which in turn
>   uses the light-weigth atomic locking syscall-interface of the Linux kernel)
> 
> Signed-off-by: Helge Deller <del...@gmx.de>
> 
> diff -up ./configure.ac.org ./configure.ac
> --- ./configure.ac.org        2014-03-29 11:02:36.928098000 -0600
> +++ ./configure.ac    2014-03-28 08:46:38.000000000 -0600
> @@ -78,6 +78,7 @@ AS_CASE([$host_cpu],
>       [ia64], [ARCHTYPE="gcc"],
>       [arm*], [ARCHTYPE="arm"],
>       [mips*], [ARCHTYPE="mips"],
> +     [hppa*], [ARCHTYPE="hppa"],
>       [ARCHTYPE="unknown"]
>  )
>  
> diff -up ./urcu/arch/hppa.h.org ./urcu/arch/hppa.h
> --- ./urcu/arch/hppa.h.org    2014-04-02 14:37:23.592098000 -0600
> +++ ./urcu/arch/hppa.h        2014-04-02 14:38:25.200098000 -0600
> @@ -0,0 +1,31 @@
> +#ifndef _URCU_ARCH_HPPA_H
> +#define _URCU_ARCH_HPPA_H
> +
> +#include <urcu/compiler.h>
> +#include <urcu/config.h>
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#include <stdlib.h>
> +#include <sys/time.h>
> +
> +typedef unsigned long cycles_t;
> +
> +static inline cycles_t caa_get_cycles(void)
> +{
> +     cycles_t cycles;
> +
> +     asm volatile("mfctl 16, %0" : "=r" (cycles));
> +
> +     return cycles;
> +}
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#include <urcu/arch/generic.h>
> +
> +#endif /* _URCU_ARCH_HPPA_H */
> diff -up ./urcu/uatomic/hppa.h.org ./urcu/uatomic/hppa.h
> --- ./urcu/uatomic/hppa.h.org 2014-04-02 14:37:36.160098000 -0600
> +++ ./urcu/uatomic/hppa.h     2014-03-28 15:02:14.000000000 -0600
> @@ -0,0 +1,10 @@
> +#ifndef _URCU_ARCH_UATOMIC_HPPA_H
> +#define _URCU_ARCH_UATOMIC_HPPA_H
> +
> +#include <urcu/compiler.h>
> +#include <urcu/system.h>
> +
> +#define UATOMIC_HAS_ATOMIC_SHORT
> +#include <urcu/uatomic/generic.h>
> +
> +#endif /* _URCU_ARCH_UATOMIC_HPPA_H */
> 
> 
> 
> === END of patch...
> 
> > 
> > ----- Original Message -----
> > > From: "Helge Deller" <del...@gmx.de>
> > > To: "Debian Bug Tracking System" <sub...@bugs.debian.org>
> > > Sent: Saturday, March 29, 2014 1:27:33 PM
> > > Subject: [lttng-dev] Bug#742979: liburcu FTBFS on hppa architecture -
> > >   patches attached
> > > 
> > > package: liburcu
> > > version: 0.7.7-1
> > > tags: patch
> > > 
> > > liburcu doesn't build yet on the hppa architecture, because the support
> > > for
> > > this architecture hasn't been developed yet.
> > > 
> > > Attached patches adds this support now.
> > > It would be nice if you could apply it to the next version of liburcu.
> > > 
> > > In the attached TGZ file you will find:
> > > - configure.ac_hppa.patch -> patch to apply to existing ./configure.ac
> > > file
> > > (adds just hppa arch detection)
> > > - urcu/arch/hppa.h  - new file, adds clock functions for hppa
> > > - urcu/uatomic/hppa.h - new file, adds atomic functions for hppa arch via
> > > gcc's built-in atomic ops.
> > > 
> > > I did tested the build with those patches on the hppa arch and ran the
> > > testsuite successfully.
> > > 
> > > Thanks!
> > > Helge
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to