Package: synaptic
Version: 0.81.1
Severity: important
I ran into the following error when trying to build synaptic.
fakeroot debian/rules clean
dh clean --with autoreconf --parallel
dh_testdir -O--parallel
debian/rules override_dh_auto_clean
make[1]: Entering directory `/«PKGBUILDDIR»'
cp debian/patches/00list.Raspbian debian/patches/00list
cp: cannot stat 'debian/patches/00list.Raspbian': No such file or directory
make[1]: *** [override_dh_auto_clean] Error 1
Investigating the source package reveals the following code (ignore the <-->
it's an artifact of how I copied and pasted).
# patch
override_dh_auto_build:
<------># apply distro specific patches if we have them
<------>if [ -e debian/patches/00list.$(DIST) ]; then \
<------> cp debian/patches/00list.$(DIST) debian/patches/00list;\
<------> dpatch apply-all;\
<------>fi;
<------>dh_auto_build $(DHFLAGS)
<------># ubuntu specific for universe langpacks but will not do any
<------># harm on debian
<------>make -C po synaptic.pot
# unpatch
override_dh_auto_clean:
<------>cp debian/patches/00list.$(DIST) debian/patches/00list
<------>dpatch deapply-all
<------>rm -rf patch-stamp debian/patched
<------>dh_auto_clean $(DHFLAGS)
So the source package checks if a patch list for the current distro exists when
patching but not when unpatching.
One could easilly add such a guard to the unpatch target as well (and I did for
a quick and dirty fix in raspbian) but the whole logic seems wrong-headed, as a
general rule unknown derivatives should get the same patches as their parent
distro (hence why we have --derives-from in dpkg-vendor), not get no patches at
all.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
