On 12-04-14 13:00, Graham Inggs wrote: > Thanks for your commits. I'm still not entirely clear on the cause of > the FTBFS.
I am too. The trigger is relocation of units, but the build.sh is working around the current failure of the lcl-qt4 package to provide pre-build units. That will be fixed soon in Lazarus. I think for the current work-around in combination with the new location, we are still missing some search path to the doublecmd build units in the new location. > Your patch to components/build.sh looks the same as the one I > attached to this bug report earlier, but that on its own didn't work > for me. No, indeed, additionally, you are missing the qt units that will be in the lcl-qt4 package when we make a new release. Not that it has anything to do with upstream, it is only the Debian packaging of Lazarus that is improved in this respect. > What do you think of modifying > debian/patches/fix_build.sh_for_lazarus-1.2.patch as below: Well, I want to get rid of this whole block with lazarus 1.2 actually, that works. Backports should than just not use the patch that removes this block. And as mentioned above, I think we are still missing one ingredient for the fix of the work around. Maybe the patch should be: if the component is in the old location do all the doublecmd workaround stuff and else skip it completely. > This should make backporting easier and allow doublecmd to continue to > build on lazarus >= 1.0.1, and we won't have to change the versions of > the lazarus and lcl* build-depends in debian/control to >= 1.2~. Yes, but as mentioned before, I don't think all this is really sane and it will be fixed in lazarus 1.2. So for Debian I think the best thing to do is bit the bullet and don't be backport compatible (or change the patch according to my comment above). > That being said, right now I'm not able to build doublecmd with > debian/add_set-e_to_build_scripts.patch and lazarus 1.0.10 (Ubuntu > Trusty). > I'll be able to test on lazarus 1.2 this coming week. Just to be sure, you need the new Debian lazarus 1.2 package. Upstream stuff doesn't matter. Paul
signature.asc
Description: OpenPGP digital signature
