Bug#743741: modem-manager-gui: fails to build with clang instead of gcc

[Nicolas Sévelin-Radiguet]

Package: modem-manager-gui
Version: 0.0.16-2
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Dear Maintainer,

Your package fails to build with clang instead of gcc. [-Wreturn-type]
The attached patch fixes it.
Buildlogs and patch are here:
https://github.com/nonas/debian-clang/tree/master/buildlogs/modem-manager-gui

Regards,
Nicolas

-- System Information:
Debian Release: jessie/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Description: fix FTBFS with clang instead of gcc
Author: Nicolas Sévelin-Radiguet <nic...@free.fr>
Last-Update: 2014-04-05

--- a/src/libpaths.c
+++ b/src/libpaths.c
@@ -294,7 +294,7 @@
 	guint ptr, start, end, entry, entries;
 	gchar *entryhash, *entryname, *entryext;
 	
-	if (libcache == NULL) return;
+	if (libcache == NULL) return 0;
 	
 	/*Cache file must be terminated with value 0x00*/
 	if (libcache->mapping[libcache->mapsize-1] != 0x00) {
--- a/src/main.c
+++ b/src/main.c
@@ -732,7 +732,7 @@
 		
 	appdata = (mmgui_application_data_t)data;
 	
-	if (appdata == NULL) return;
+	if (appdata == NULL) return FALSE;
 	
 	currenttime = time(NULL);
 	
@@ -1425,7 +1425,7 @@
 	
 	mmguiapp = (mmgui_application_t)data;
 	
-	if (mmguiapp == NULL) return;
+	if (mmguiapp == NULL) return FALSE;
 	
 	if (mmguiapp->options->askforhide) {
 		/*Ask at exit*/
@@ -1752,7 +1752,7 @@
 	
 	mmguiapp = (mmgui_application_t)data;
 	
-	if (mmguiapp == NULL) return;
+	if (mmguiapp == NULL) return FALSE;
 	
 	if (mmguicore_devices_get_current(mmguiapp->core) != NULL) {
 		unreadmessages = mmgui_smsdb_get_unread_messages(mmguicore_devices_get_sms_db(mmguiapp->core));
@@ -1795,7 +1795,7 @@
 	guint id, contacttype;
 	mmgui_contact_t contact;
 	
-	if (mmguiapp == NULL) return;
+	if (mmguiapp == NULL) return 0;
 	
 	model = gtk_tree_view_get_model(GTK_TREE_VIEW(mmguiapp->window->contactstreeview));
 	selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(mmguiapp->window->contactstreeview));
@@ -2958,8 +2958,8 @@
 	
 	mmguiapp = (mmgui_application_t)data;
 	
-	if (mmguiapp == NULL) return;
-	if (mmguiapp->core == NULL) return;
+	if (mmguiapp == NULL) return FALSE;
+	if (mmguiapp->core == NULL) return FALSE;
 	
 	device = mmguicore_devices_get_current(mmguiapp->core);
 	
@@ -2995,8 +2995,8 @@
 		
 	mmguiapp = (mmgui_application_t)data;
 	
-	if (mmguiapp == NULL) return;
-	if (mmguiapp->core == NULL) return;
+	if (mmguiapp == NULL) return FALSE;
+	if (mmguiapp->core == NULL) return FALSE;
 	
 	device = mmguicore_devices_get_current(mmguiapp->core);
 	
@@ -4183,7 +4183,7 @@
 	gint smsvalidflags;
 	enum _mmgui_main_new_sms_dialog_result result;
 	
-	if (mmguiapp == NULL) return;
+	if (mmguiapp == NULL) return 0;
 	
 	smsvalidflags = MMGUI_MAIN_NEW_SMS_VALIDATION_VALID;