El Tue, 1 de Apr 2014 a las 4:05 AM, Dimitri John Ledkov <x...@debian.org> escribió:
On 26 March 2014 10:46, Simon McVittie <s...@debian.org> wrote:
 On Tue, 25 Mar 2014 at 22:41:32 -0007, Cameron Norman wrote:
‘2’
i can subscribe to dbus package in debian.


I feel very stupid because I literally can not figure out how to subscribe to a package's bug reports in Debian. I have subscribed to the Utopia ML, though, and will watch for any problems with Upstart.

 +stop on deconfiguring-networking


This is correct.

 This appears to have caused some rather upset bug reports in Ubuntu

These problems are unrelated to dbus package, and are not bugs dbus
job. Despite the confusing state the user's machines were left in =)))
It was a bug in upstart jobs in the ifupdown package which has been
resolved recently.


I will change that back then.

 +start on local-filesystems

 Similarly, this doesn't necessarily provide /usr.


    start on remote-filesystems

is emitted after /usr and all virtual filesystems are available (/run
et al). Maybe that's a better fit on Debian.


Are you sure? man tells me that it is when all remote fs are mounted, which does not include local filesystems (e.g. a separate, but non-NFS, /usr). filesystem is what we want, no? Also, dbus needs /var because it does not use /run yet, so it needs filesystem anyway.

I have attached the changes (using filesystem, not remote-filesystems), and hope this can be merged soon, Simon.

Thanks,
--
Cameron Norman
diff -Nru dbus-1.8.0/debian/changelog dbus-1.8.0/debian/changelog
--- dbus-1.8.0/debian/changelog	2014-02-26 05:15:58.000000000 -0800
+++ dbus-1.8.0/debian/changelog	2014-03-25 15:32:27.000000000 -0700
@@ -1,3 +1,15 @@
+dbus (1.8.0-2.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Add Upstart integration:
+    - Check if init is upstart in the init.d script and exit
+      appropiately
+    - Add Upstart job
+    - Depend on lsb-base that provides init_is_upstart function
+    - Prompt for reboot on post-install always
+
+ -- Cameron Norman <camerontnor...@gmail.com>  Tue, 25 Mar 2014 15:29:17 -0700
+
 dbus (1.8.0-2) unstable; urgency=low
 
   * debian/rules: look for DEB_BUILD_PROFILES, the new name for
diff -Nru dbus-1.8.0/debian/control dbus-1.8.0/debian/control
--- dbus-1.8.0/debian/control	2014-02-26 05:15:58.000000000 -0800
+++ dbus-1.8.0/debian/control	2014-03-25 15:29:10.000000000 -0700
@@ -57,7 +57,7 @@
 Depends: ${shlibs:Depends},
          ${misc:Depends},
          adduser,
-         lsb-base (>= 3.2-14)
+         lsb-base (>= 4.1+Debian3)
 Suggests: dbus-x11
 Multi-Arch: foreign
 Description: simple interprocess messaging system (daemon and utilities)
diff -Nru dbus-1.8.0/debian/dbus.init dbus-1.8.0/debian/dbus.init
--- dbus-1.8.0/debian/dbus.init	2014-02-26 05:15:58.000000000 -0800
+++ dbus-1.8.0/debian/dbus.init	2014-03-25 15:27:16.000000000 -0700
@@ -97,6 +97,17 @@
   log_action_end_msg $?
 }
 
+if init_is_upstart; then
+  case "$1" in
+    stop)
+      exit 0
+    ;;
+    *)
+      exit 1
+    ;;
+  esac
+fi
+
 case "$1" in
   start)
     start_it_up
diff -Nru dbus-1.8.0/debian/dbus.postinst dbus-1.8.0/debian/dbus.postinst
--- dbus-1.8.0/debian/dbus.postinst	2014-02-26 05:15:58.000000000 -0800
+++ dbus-1.8.0/debian/dbus.postinst	2014-03-25 14:51:12.000000000 -0700
@@ -38,11 +38,9 @@
     # system bus is not supported by upstream). The code added by
     # dh_installinit -r creates a start action, below.
 
-    if [ -x "/etc/init.d/dbus" ] && /etc/init.d/dbus status > /dev/null; then
-        # trigger an update notification which recommends to reboot
-        [ -x /usr/share/update-notifier/notify-reboot-required ] && \
-            /usr/share/update-notifier/notify-reboot-required || true
-    fi
+    # trigger an update notification which recommends to reboot
+    [ -x /usr/share/update-notifier/notify-reboot-required ] && \
+        /usr/share/update-notifier/notify-reboot-required || true
 fi
 
 # This is what the init script would do, but it's simpler (and less
diff -Nru dbus-1.8.0/debian/dbus.upstart dbus-1.8.0/debian/dbus.upstart
--- dbus-1.8.0/debian/dbus.upstart	1969-12-31 16:00:00.000000000 -0800
+++ dbus-1.8.0/debian/dbus.upstart	2014-03-25 15:24:38.000000000 -0700
@@ -0,0 +1,25 @@
+# dbus - D-Bus system message bus daemon
+#
+# The D-Bus system message bus allows system daemons
+# and user applications to communicate.
+
+description "dbus - D-Bus system message bus daemon"
+
+start on filesystem
+stop on deconfiguring-networking
+
+oom score -900
+
+expect fork
+respawn
+
+pre-start script
+	mkdir -p /var/run/dbus
+	chown messagebus:messagebus /var/run/dbus
+	
+	exec dbus-uuidgen --ensure
+end script
+
+exec dbus-daemon --system --nopidfile --fork
+
+post-start exec kill -USR1 1

Reply via email to