Package: cronolog
Version: 1.6.2+rpk-1
Severity: wishlist
Tags: upstream

When you run cronolog successfully it exits with a non-zero exit code
due to this bit of code in main():

    n_bytes_read = read(0, read_buf, sizeof read_buf);
    if (n_bytes_read == 0)
    {
        exit(3);
    }

I.e. if it has no more bytes to read it exits with non-zero, this is
most unusual for programs check the successful exit status of spawned
programs.

Since this looks intentional this should be documented prominently in
the manpage, along with the other exit codes, from the source via
Emacs's "M-x occur RET exit( RET":

11 matches for "exit(" in buffer: cronolog.c
    213:                exit(1);
    233:                exit(1);
    254:            exit(0);
    259:            exit(1);
    266:        exit(1);
    277:            exit(1);
    301:            exit(1);
    319:            exit(3);
    327:            exit(4);
    362:            exit(5);
    417:        exit(2);

Documenting when and why it exits with 0..5 would be really useful.


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'unstable'), (700, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cronolog depends on:
ii  dpkg          1.17.6
ii  install-info  5.2.0.dfsg.1-2
ii  libc6         2.18-4
ii  perl          5.18.2-2+b1

cronolog recommends no packages.

cronolog suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to