Dear Nick, sorry for the delay, I was on holidays. I compared your proposed 1.8.3 with 1.8.2, and found that you replaced constants from header files found in postgresql-server-dev-9.3 by the numbers they represent.
I was able to solve the problem by build-depending on postgresql-server-dev-9.3, so we (Debian) do not require you to do that change. It is up to you which variant you prefer: Less magic numbers in your code, but your users will have to install postgresql-server-dev-<some-version> before building the package, or the change that you proposed as 1.8.3. From my point of view, either works fine. Thanks, Joachim Am Sonntag, den 23.03.2014, 09:03 +0100 schrieb Nick Rudnick: > Dear all, > > > the update attached seems to work for me – for you too?? > > > If yes, it can be put to Hackage. > > > Cheers, Nick > > > 2014-03-21 21:31 GMT+01:00 Nick Rudnick <nick.rudn...@gmail.com>: > Hi all, > > > this weekend, finally, I have plenty of time to adapt > hsql-postgresql. > > > Thanks to everybody from my side, too. :-) > > > 2014-03-21 20:27 GMT+01:00 Joachim Breitner > <nome...@debian.org>: > > Hi, > > Am Montag, den 17.03.2014, 11:05 +0100 schrieb > Christoph Berg: > > The OIDs of the exposed datatypes won't ever change, > so B-D on > > postgresql-server-dev-all is safe even if -9.3 will > be replaced by > > -9.4 or later in the future. > > thanks. I added the B-D. > > > What worries me, though, is this: > > > > Build-Conflicts: > > postgresql-server-dev-8.3, > > postgresql-server-dev-8.4 > > > > haskell-hsql-postgresql (1.7.3-2) unstable; > urgency=low > > > > * Make postgresql-server-dev-8.[34] a > Build-Conflicts (Closes: 559583) > > If this package is present at build-time, the > resulting ghc-pkg info will > > reference a directory from it in Includes, > causing the installation to > > fail (see #471786). But if it is not, everything > goes well and we have one > > dependency less. > > > > -- Joachim Breitner <nome...@debian.org> Sat, 05 > Dec 2009 17:10:34 +0100 > > > > I cannot reproduce the problem here with > postgresql-server-dev-9.3 > > installed - the deps of the resulting .debs are the > same, but I didn't > > look into the package for file references in there. > > Installing the new package will yield a warning > Warning: > include-dirs: /usr/include/postgresql/9.3/server > doesn't exist or isn't a directory > but not an error any more, so I think this is fine. > > Uploading right now. > > Thanks for your help, Christoph, > Joachim > > > -- > Joachim "nomeata" Breitner > Debian Developer > nome...@debian.org | ICQ# 74513189 | GPG-Keyid: > 4743206C > JID: nome...@joachim-breitner.de | > http://people.debian.org/~nomeata > > > > -- Joachim "nomeata" Breitner Debian Developer nome...@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata
signature.asc
Description: This is a digitally signed message part