Bug#742220: libreadline-java: fails to build with clang instead of gcc

[Nicolas Sévelin-Radiguet]

Source: libreadline-java
Version: 0.8.0.1+dfsg-2
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Dear Maintainer,

Your package fails to build with clang instead of gcc. [-Wreturn-type]
The attached patch fixes it.
Buildlogs and patch are here:
https://github.com/nonas/debian-clang/tree/master/buildlogs/libreadline-java

Regards,
Nicolas

-- System Information:
Debian Release: jessie/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Description: fix FTBFS with clang instead of gcc
Author: Nicolas Sévelin-Radiguet <nic...@free.fr>
Last-Update: 2014-03-20

--- a/src/native/org_gnu_readline_Readline.c
+++ b/src/native/org_gnu_readline_Readline.c
@@ -654,7 +654,7 @@
   jtext = (*jniEnv)->NewStringUTF(jniEnv,text);
 
   if (jniMethodId == 0) {
-    return;
+    return ((const char *)NULL);
   }
 
   completion = (*jniEnv)->CallObjectMethod(jniEnv, jniObject,
@@ -829,7 +829,7 @@
       newExcCls = (*env)->FindClass(env,"java/lang/OutOfMemoryError");
       if (newExcCls != NULL)
         (*env)->ThrowNew(env,newExcCls,"");
-      return;    
+      return NULL;    
     }
   } else
     oldValue = NULL;
@@ -844,7 +844,7 @@
     newExcCls = (*env)->FindClass(env,"java/io/UnsupportedEncodingException");
     if (newExcCls != NULL)
       (*env)->ThrowNew(env,newExcCls,"");
-    return;
+    return NULL;
   }
   if (is_copy == JNI_TRUE)
     (*env)->ReleaseStringUTFChars(env,jvalue,newValue);