Package: git
Version: 1:1.9.0-1
Severity: normal
File: /usr/share/gitweb/static/gitweb.js
Tags: patch upstream

Hi,

The following setting in gitweb.conf
 $feature{'javascript-actions'}{'default'} = [1];
breaks the gitweb's blame page: clicking on line numbers displayed in
the second column on the page does absolutelly nothing (at least 
in iceweasel and chromium browsers). Without this setting, clicking on
line numbers loads the previous version of the line.

The patch below fixes the issue:

--- gitweb.js.old       2014-03-16 22:46:05.000000000 +0100
+++ gitweb.js   2014-03-16 22:46:12.000000000 +0100
@@ -1371,7 +1371,7 @@
                        case 'previous':
                                curCommit.nprevious++;
                                // store only first 'previous' header
-                               if (!'previous' in curCommit) {
+                               if (!('previous' in curCommit)) {
                                        var parts = data.split(' ', 2);
                                        curCommit.previous    = parts[0];
                                        curCommit.file_parent = 
unquote(parts[1]);


Regards,
robert



-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (200, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.11-2-686-pae (SMP w/1 CPU core)
Locale: LANG=pl_PL.UTF8, LC_CTYPE=pl_PL.UTF8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages git depends on:
ii  git-man          1:1.9.0-1
ii  libc6            2.18-4
ii  libcurl3-gnutls  7.35.0-1
ii  liberror-perl    0.17-1.1
ii  libexpat1        2.1.0-4
ii  libpcre3         1:8.31-2
ii  perl-modules     5.18.2-2
ii  zlib1g           1:1.2.8.dfsg-1

Versions of packages git recommends:
ii  less                         458-2
ii  openssh-client [ssh-client]  1:6.5p1-6
ii  patch                        2.7.1-4
ii  rsync                        3.1.0-2

Versions of packages git suggests:
ii  gettext-base                          0.18.3.2-1
pn  git-arch                              <none>
pn  git-bzr                               <none>
pn  git-cvs                               <none>
pn  git-daemon-run | git-daemon-sysvinit  <none>
ii  git-doc                               1:1.9.0-1
pn  git-el                                <none>
ii  git-email                             1:1.9.0-1
ii  git-gui                               1:1.9.0-1
pn  git-mediawiki                         <none>
ii  git-svn                               1:1.9.0-1
ii  gitk                                  1:1.9.0-1
ii  gitweb                                1:1.9.0-1

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/gitweb/static/gitweb.js (from git package)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to