On Fri, Mar 14, 2014 at 9:27 AM, Jim Meyering <j...@meyering.net> wrote: > On Fri, Mar 14, 2014 at 4:49 AM, Pádraig Brady <p...@draigbrady.com> wrote: > ... >> Hence since c_f_m() can validly fail even with CAN_MISSING, >> I agree your patch is correct. >> >> Please push. > > Done.
Hmm... For the record, I also pushed (accidentally) two additional changes that had been languishing in the affected repository. Here they are:
From 42d2377b813507d50f5a67076bb20134ceb2fc10 Mon Sep 17 00:00:00 2001 From: Jim Meyering <j...@meyering.net> Date: Mon, 5 Aug 2013 07:28:34 -0700 Subject: [PATCH 1/2] scripts: autotools-install: update * scripts/autotools-install: Update version numbers of latest automake and gettext packages. --- scripts/autotools-install | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/autotools-install b/scripts/autotools-install index 403644f..c6a8e36 100755 --- a/scripts/autotools-install +++ b/scripts/autotools-install @@ -24,9 +24,9 @@ tarballs=' http://pkgconfig.freedesktop.org/releases/pkg-config-0.28.tar.gz http://ftp.gnu.org/gnu/m4/m4-1.4.16.tar.gz http://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz - http://ftp.gnu.org/gnu/automake/automake-1.12.6.tar.gz + http://ftp.gnu.org/gnu/automake/automake-1.14.tar.gz http://ftp.gnu.org/gnu/libtool/libtool-2.4.2.tar.gz - http://ftp.gnu.org/gnu/gettext/gettext-0.18.2.tar.gz + http://ftp.gnu.org/gnu/gettext/gettext-0.18.3.tar.gz ' usage() { -- 1.9.0.167.g384364b From 4f211822dddd1777dc915f2df4e2ed3b65c68301 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@fb.com> Date: Mon, 18 Nov 2013 10:13:06 -0800 Subject: [PATCH 2/2] maint: avoid "attribute-const"-suggesting warning from gcc * gl/lib/fadvise.c: Use a pragma to turn off this warning option: -Wsuggest-attribute=const. Without this change, building with --enable-gcc-warnings would evoke this error: lib/fadvise.c:25:1: error: function might be candidate for\ attribute 'const' [-Werror=suggest-attribute=const] --- gl/lib/fadvise.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gl/lib/fadvise.c b/gl/lib/fadvise.c index 3456ce1..562f1eb 100644 --- a/gl/lib/fadvise.c +++ b/gl/lib/fadvise.c @@ -14,6 +14,12 @@ You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. */ +/* Without this pragma, gcc suggests that (given !HAVE_POSIX_FADVISE) + the the fdadvise function might be candidate for attribute 'const'. */ +#if (__GNUC__ == 4 && 6 <= __GNUC_MINOR__) || 4 < __GNUC__ +# pragma GCC diagnostic ignored "-Wsuggest-attribute=const" +#endif + #include <config.h> #include "fadvise.h" -- 1.9.0.167.g384364b
