Package: python-boto Version: 2.25.0-1 Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu ubuntu-patch trusty User: autopkgtest-de...@lists.alioth.debian.org Usertags: autopkgtest
Hello, python-boto's autopkgtest currently fails on Ubuntu [1]: | Traceback (most recent call last): | File "/usr/lib/python2.7/dist-packages/nose/loader.py", line 413, in loadTestsFromName | addr.filename, addr.module) | File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 47, in importFromPath | return self.importFromDir(dir_path, fqname) | File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 94, in importFromDir | mod = load_module(part_fqname, fh, filename, desc) | File "/tmp/adt-downtmp/apt0-build/python-boto-2.20.1/tests/unit/cloudsearch/test_connection.py", line 5, in <module> | from boto.cloudsearch.domain import Domain | File "/tmp/adt-downtmp/apt0-build/python-boto-2.20.1/boto/cloudsearch/domain.py", line 31, in <module> | from .document import DocumentServiceConnection | File "/tmp/adt-downtmp/apt0-build/python-boto-2.20.1/boto/cloudsearch/document.py", line 27, in <module> | import requests | ImportError: No module named requests Indeed python-boto uses python-requests without depending on it. The autopkgtest in Debian [2] hides that because in Debian python-httpretty depends on python-requests (but not in Ubuntu), but that won't help at runtime. That part is easily fixed. However, when fixing that I noticed that python-boto's autopkgtest does not actually depend on python-boto. I. e. what the autopkgtest does is just to run the tests against the source tree, not the installed package. autopkgtests need to do the latter, otherwise you have no chance to discover install/packaging errors. So please add a test dependency on @ (or explicitly python-boto) and make the tests run against the installed package. Thanks for considering, Martin [1] https://jenkins.qa.ubuntu.com/job/trusty-adt-python-boto-armhf/1/console [2] http://ci.debian.net/#package/python-boto -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -u python-boto-2.25.0/debian/changelog python-boto-2.25.0/debian/changelog
--- python-boto-2.25.0/debian/changelog
+++ python-boto-2.25.0/debian/changelog
@@ -1,3 +1,12 @@
+python-boto (2.25.0-1ubuntu1) trusty; urgency=medium
+
+ * Add missing python-requests dependency, spotted by autopkgtest.
+ * Add python-requests test dependency, as the test does not actually depend
+ on python-boto (this test needs to be fixed to run against the installed
+ package).
+
+ -- Martin Pitt <martin.p...@ubuntu.com> Wed, 26 Feb 2014 15:36:33 +0100
+
python-boto (2.25.0-1) unstable; urgency=medium
* New upstream release.
diff -u python-boto-2.25.0/debian/control python-boto-2.25.0/debian/control
--- python-boto-2.25.0/debian/control
+++ python-boto-2.25.0/debian/control
@@ -12,7 +13,7 @@
Package: python-boto
Architecture: all
-Depends: ${python:Depends}, ${misc:Depends}
+Depends: ${python:Depends}, ${misc:Depends}, python-requests
Provides: ${python:Provides}
Description: Python interface to Amazon's Web Services
Boto is a Python interface to the infrastructure services available from
diff -u python-boto-2.25.0/debian/tests/control
python-boto-2.25.0/debian/tests/control
--- python-boto-2.25.0/debian/tests/control
+++ python-boto-2.25.0/debian/tests/control
@@ -1,3 +1,3 @@
Tests: unit
-Depends: python-all (>= 2.6.6-3), python-nose (>= 1.3.0), python-mock (>=
1.0.1), python-httpretty (>= 0.6.3)
+Depends: python-all (>= 2.6.6-3), python-nose (>= 1.3.0), python-mock (>=
1.0.1), python-httpretty (>= 0.6.3), python-requests
Restrictions: allow-stderr
signature.asc
Description: Digital signature
