-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 15/02/14 23:38, gregor herrmann wrote: > On Sat, 15 Feb 2014 22:33:15 +0000, Daniel Lintott wrote: > >>> replace "dh $@" with "dh $@ --buildsystem=perl_makemaker" then >>> dh will use Makefile.PL etc. and everything looks good > >> The only snag is still going to be the missing LDFLAGS (relro in >> particular) for Socket6.so > > Hm, I'm not sure about that. Neither lintian nor blhc complained > when I tried this approach. > > (And usually debhelper with compat level 9 just passes all > required flags, and they are used unless the upstream build system > messes with %Config in some crazy way). > > How/where did you see the problem? > > > When I build it again (with --buildsystem and without the override) > I get: > [SNIP] > > > which looks quite ok to me :) -fstack-protector is there, and also > -Wl,-z,relro. > >> Would it be preferable to patch the config.pl.in and add all the >> LDDLFLAGS there as opposed to in the rules file? > > If it's necessary that's an option. A bit more idiomatic would be > an override that just adds missing stuff, like (untested) > > override_dh_auto_configure: dh_auto_configure -- LDDLFLAGS="..." > > > Cheers, gregor, who might well be missing something ... >
And sorted! It was the override causing the problem with the missing flags, so that's now rectified. I have made the necessary alterations to d/rules, released the changelog and pushed the changes to git. I haven't tagged the build as yet, as I wasn't sure exactly when you wanted this done? Regards, Daniel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJTAKuEAAoJEMw/9yOWzAkJYUQH/0+MepUrTgJpW9GbJRQJ+uKs a0ao+AMoO8bLDaq59EDzC8VlzylD+Ad6SfncmMp4zRohifQgNU2BL3+Fm/mVT5Z3 NJ3YdHtC1mGhA/c5o7pfAt6pyggveMGl+dudgAfQMuxi+WjWkMY251x20BUbC0/J 0Sa+Je0XURilpX6WR5puX+oy4Z0OmeX3F53cB3djMArMDlivjXooETOuepAw8ZRT j+Cpx5rn16eIjr5cGDvCNHD/FxVhZnK4yd6jQi4XCT0B32Qxipo9yMDn4ar3p7Tt XCorC0wCF5VvdrJ8guiPqVaGkanOpK4lWK7bvqdyeiavw/pPGTkD4eiYyNsBp/c= =nDq+ -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
