Hi,
I think the service file for smartmontools could be improved:
* Add a reference to the documentation in the [Unit] section, e.g.:
Documentation=man:smartd(8) man:smartd.conf(5)
* The 'EnvironmentFile=-/usr/local/etc/sysconfig/smartmontools' does
not exist in Debian, it is rather /etc/default/smartmontools.
Furthermore this should not be in the unit file, as it contains only
three configuration options, two of which (enable_smart, start_smartd)
are completely ignored by the service file and the third (smartd_opts)
is only for additional command line options, that should better be
changed in the service file itself.
So Debian could just drop this line (and remove the $smartd_opts
from the command line), but if the maintainer wants to follow upstream,
at least the path should be updated in Debian.
Michael, I see that you requested the removal of 'EnvironmentFile=' in
[1], but upstream decided against it...
Could you request to add the 'Documentation=' line upstream? (I don't
have an account there.)
By the way, I manually installed the service file in /etc/systemd/system
and it works well for me. It would be great, if the patch would be
applied in the next package upload.
Best regards,
Andreas
1: http://sourceforge.net/apps/trac/smartmontools/ticket/194
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
