Package:ethstatus
Version:0.4.3

Hello there,

Static analyser cppcheck just said

[ethstatus.c:685] -> [ethstatus.c:685]: (style) Same expression on both sides 
of '||'.
[ethstatus.c:687] -> [ethstatus.c:687]: (style) Same expression on both sides 
of '||'.

Source code is

                else if (modifier == 'm' || modifier == 'm')
                    KBps *= 1024;
                else if (modifier == 'g' || modifier == 'g')
                    KBps *= (1024*1024);

Maybe

                else if (modifier == 'm' || modifier == 'M')
                    KBps *= 1024;
                else if (modifier == 'g' || modifier == 'G')
                    KBps *= (1024*1024);

might be better code.

Regards

David Binderman                                           

--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to