Hey, Thank You very much for your suggestions !!
Here is a link [1] to the package fixed according to your suggestions. [1] https://mentors.debian.net/package/kerneltop On 4 February 2014 03:42, Liang Guo <bluestonech...@gmail.com> wrote: > Interesting package, this is my review: > > 1 upstream ships manpage, so please remove debian/kerneltop.1 > 2 3.0 (quilt) always use quilt to manage patches, so README.source is > meaningless, please remove > 3 Upstream makefile don't use CFLAGS environmen which includes build > harden flags. I advice you pach "CCFLAGS=-g/-s" in makefile with > "CCFLAGS=-g/-s $(CFLAGS)" to include build harden flags and remove > debian/source/lintian-overrides > 4 Please update debian/copyright with DEP5 format[2]. > > Thanks for your working on debian. > > > [1] https://wiki.debian.org/Hardening > [2] http://dep.debian.net/deps/dep5/ > > -- > Liang Guo > http://guoliang.me > -- Pozdrawiam, Dariusz Dwornikowski, Assistant Institute of Computing Science, Poznań University of Technology www.cs.put.poznan.pl/ddwornikowski/ room 2.7.2 BTiCW | tel. +48 61 665 29 41
