Hi,
On Thu, Jan 30, 2014 at 02:47:41PM -0400, Joey Hess wrote:
> This looks good, but have you checked that all of the places
> $config{useragent} is passed to do the right thing when it is undef?
Yes I have.Case 1: IkiWiki::useragent() using LWP::UserAgent->new(). $agent variable defined from the option hash passed to LWP::UserAgent->new(): https://metacpan.org/source/GAAS/libwww-perl-6.05/lib/LWP/UserAgent.pm#L28 Value of $agent variable checked with defined(), if undef using the default implementation as if no agent key passed to LWP::UserAgent->new() at all: https://metacpan.org/source/GAAS/libwww-perl-6.05/lib/LWP/UserAgent.pm#L112 Case 2: Where LWPx::ParanoidAgent->new() is being used. LWPx::ParanoidAgent is a sub-class of LWP::UserAgent, so option hash passed to LWPx::ParanoidAgent->new() is used as with LWP::UserAgent->new(): https://metacpan.org/source/SAXJAZMAN/LWPx-ParanoidAgent-1.10/lib/LWPx/ParanoidAgent.pm#L22 https://metacpan.org/source/SAXJAZMAN/LWPx-ParanoidAgent-1.10/lib/LWPx/ParanoidAgent.pm#L30 On a related note, should the cookie jar option be passed when using LWPx::ParanoidAgent->new()? So I think it's ok. br, Tuomas > > -- > see shy jo
signature.asc
Description: Digital signature
