Package: libgusb
Version: 0.1.6-4
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu trusty ubuntu-patch

Hi Michal,

The libgusb package in Ubuntu has a few changes with respect to the Debian
package, which I think it would be suitable to include in Debian.  I don't
think these warrant individual bug reports since they're all quite small, so
I'm attaching a single patch with explanation.

The changes are:

  * build-depend on valac (>= 0.20), not valac-0.20.
    - this was mentioned by pochu in bug #707465: we don't want to
      hard-code the dependency on a specific version of vala.
  * have libgusb-dev depend on gir1.2-gusb-1.0.
    - this is so that the gir typelib is available at build-time for vala.
  * install typelib to /usr/lib as expected, not to the multiarch dir.
    - I don't think g-i-r has support yet for looking for typelibs in
      multiarch directories.
  * keep libgusb2.symbols at version 0.1.5 for compatibility with
    existing Ubuntu builds.
    - this doesn't matter for Debian since 0.1.5 was never in the archive,
      but it matters for Ubuntu and is technically correct to apply to
      Debian as well.
  * Call dh --with gir.
    - without this call, the gir package does not have proper dependencies.

Thanks for considering the patch.
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
=== modified file 'debian/control'
--- debian/control	2014-01-20 16:04:03 +0000
+++ debian/control	2014-01-27 09:49:21 +0000
@@ -10,7 +10,7 @@
     gobject-introspection (>= 1.29),
     libgirepository1.0-dev (>= 1.29),
     gtk-doc-tools,
-    valac-0.20
+    valac (>= 0.20)
 Standards-Version: 3.9.5
 Section: libs
 Homepage: http://www.hughski.com/downloads.html
@@ -24,7 +25,8 @@
     ${misc:Depends},
     gir1.2-gusb-1.0,
     libgudev-1.0-dev,
-    libusb-1.0-0-dev
+    libusb-1.0-0-dev,
+    gir1.2-gusb-1.0,
 Description: GLib wrapper around libusb1 - development files
  GUsb is a GObject wrapper for libusb1 that makes it easy to do
  asynchronous control, bulk and interrupt transfers with proper

=== modified file 'debian/gir1.2-gusb-1.0.install'
--- debian/gir1.2-gusb-1.0.install	2014-01-20 16:04:03 +0000
+++ debian/gir1.2-gusb-1.0.install	2014-01-27 08:49:07 +0000
@@ -1 +1 @@
-usr/lib/*/girepository-1.0/GUsb-1.0.typelib
+usr/lib/*/girepository-1.0 usr/lib

=== modified file 'debian/libgusb2.symbols'
--- debian/libgusb2.symbols	2013-03-08 09:52:33 +0000
+++ debian/libgusb2.symbols	2014-01-27 08:56:10 +0000
@@ -35,8 +35,8 @@
  g_usb_device_list_new@Base 0.1.3
  g_usb_device_open@Base 0.1.3
  g_usb_device_release_interface@Base 0.1.3
- g_usb_device_reset@Base 0.1.6
+ g_usb_device_reset@Base 0.1.5
  g_usb_device_set_configuration@Base 0.1.3
  g_usb_source_error_quark@Base 0.1.3
  g_usb_source_set_callback@Base 0.1.3
- g_usb_strerror@Base 0.1.6
+ g_usb_strerror@Base 0.1.5

=== modified file 'debian/rules'
--- debian/rules	2014-01-20 16:04:03 +0000
+++ debian/rules	2014-01-27 09:33:10 +0000
@@ -21,4 +21,4 @@
 	echo "Skipping tests as they fail in build environment due to USB bus not available"
 
 %:
-	dh $@ --with autoreconf
+	dh $@ --with autoreconf,gir

Reply via email to