On Wed, Nov 27, 2013 at 11:51:46PM +0100, Raúl Sánchez Siles wrote: > Available at mentors: > > http://mentors.debian.net/package/libsodium > > Note this package is subject to changes.
Hi Raul,
would you be interested in maintaining this package in Debian? If so, I'd be
available for sponsoring you.
I've had a look at your package and I have a few comments:
* There's no need to Build-Depends and use both autotools-dev and dh-autoreconf,
the latter is enough.
* I think you need to Build-Depends on pkg-config too, otherwise the *.pc file
is not generated and the build fails when dh_install tries to install it.
* Standards-Version should be updated to 3.9.5.
* The *.shlibs file is kinda useless since you included the *.symbols file too.
* The changelog file has an outdated Format URL, it should be:
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
* The changelog doesn't list the files authored by djb. While they are in the
public domain they should be documented as well, using something as:
License: public-domain
NaCl was written by Daniel J. Bernstein, and is placed in the public
domain.
as license.
* The packages' short descriptions should not end with a full stop ".".
* You should probably install the README.markdown file (and possibly the THANKS
and AUTHORS) too as documentation.
* You should probably add a paragraph to the -dev and -dbg packages' long
descriptions (such as "This package provides the {development files,debug
symbols} for libsodium-" so that they are no identical to the libsodium4 one.
That's all for now (but I may have missed something).
Cheers
--
perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
signature.asc
Description: Digital signature
