On Fri, Jan 17, 2014 at 1:12 AM, Jan-Pascal van Best <janpas...@vanbest.org> wrote: > Hi Vincent, > > Thank you for your review! > > >> debian/copyright: >> - missing license entry for images/ttf/liberation-sans/* (even if you >> don't ship the embedded font files, if they're in the source tarball, >> they need to be acknowledged in debian/copyright) > > Thanks for spotting this. An earlier version if the upstream package shipped > non-free font files, which I had removed from the dfsg source. Looking at > the license file in images/ttf/liberation-sans/License.txt, it looks like > these, > too, may need to be considered non-free, since it contains export control > limitations in section 3. (these are not present in the copyright text of > the > Debian ttf-liberation font package). I can either move the license text to > debian/copyright (including the export control limitations), or completely > remove the font files from the dfsg source package. Which would you advise?
Ah, I hadn't noticed that the license file in that directory doesn't contain the same terms as the ttf/fonts-liberation packages. I suppose it's probably safer just to remove the those fonts then, especially since you're already repackaging the source tarball anyways. >> - your "License: Apache-2" standalone section is incomplete; you >> should include the text of Apache 2.0's Appendix (i.e. the license >> header in lib/notifications/prowl/*)A > > Fixed. > > >> Nice to have: >> >> debian/changelog: Please collapse all your newest changelogs into a single >> one > > Done. > > >> debian/control: Consider depending on libapache2-mod-php5 | php5 and >> php5-mysql | php5-mysqlnd > > Wouldn't depending on libapache2-mod-php5 | php5 cause apt-get to allow > installing spotweb on systems having just apache2 and php5-cli? $ apt-cache depends php5 php5 |Depends: libapache2-mod-php5 |Depends: libapache2-mod-php5filter |Depends: php5-cgi Depends: php5-fpm Depends: php5-common > Thanks again for your effort in reviewing this package, I had almost given > up on it! Unfortunately getting a sponsor through mentors.d.n/sponsorship-requests can take quite some time. I've made it a goal of mine to take a look at some RFS bugs on a regular basis; I know firsthand how hard it was at times to get a sponsor pre-DM/DD. Regards, Vincent P.S. Please don't forget to cc: 720924@b.d.o -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
