On Sun, Jan 05, 2014 at 01:41:38PM -0800, Russ Allbery wrote:
> Colin Watson <cjwat...@debian.org> writes:
> > Thanks! I have a number of review comments below, but in general I'm
> > happy with the approach taken here and will be happy to merge it after a
> > few fixes. I very much appreciate your work here.
>
> No problem. An updated patch is attached that reflects your comments.
Thanks, this looks great now. I've made some changes of my own on top
of this, not least fixing #274229, have pushed all this to master, and
will release it once I've done a bit more testing.
> >> + Move user "${name}" (${id}) to before the "+" entry
>
> > I wonder if it's worth saying something about NIS compat in this and in
> > base-passwd/group-move; not that this is original to your patch, but
> > it's worth thinking about since these strings will be translated.
>
> I changed this to "before the NIS compat "+" entry". If more should be
> said, can I defer to you for the wording? I actually have no idea why
> update-passwd does this, and reading the passwd man page didn't enlighten
> me. (It's been eons since I used NIS, and I've never used compat mode.)
I think this will do for the moment. This code was to fix #166756,
FWIW.
> In general, I tried to use the existing coding style as best as I could
> follow it. You noticed another place where I didn't get my editor to use
> tabs aggressively enough (I never use tabs in source). I think I cleaned
> all of that up as well in this version.
update-passwd's style isn't my favourite, but I appreciate that - it's
better to be consistent than use either of our pet styles. :-)
--
Colin Watson [cjwat...@debian.org]
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
