Source: imlib2
Version: 1.4.6-1
Severity: normal
Tags: patch

Running /usr/bin/imlib2-config --libs gives:
-L/usr/lib/aarch64-linux-gnu -lImlib2 @my_libs@

That @my_libs@ is wrong. And can break builds which use these flags
(such as w3m on arm64, for example). It should have been substituted
with something, but there seems to be nothing in the package to do that
substitution when imlib2-config.in is generated into imlib2-config

I'm not sure what the original idea was, but the @my_libs@ seems to be 
redundant now.

The attached patch just removes it so that the package produces a
version of imlib2-config that produces a valid output for --libs

-- System Information:
Debian Release: 7.3
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-kvm-i386-20110111 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru imlib2-1.4.6/debian/changelog imlib2-1.4.6/debian/changelog
--- imlib2-1.4.6/debian/changelog	2013-12-27 11:35:17.000000000 +0000
+++ imlib2-1.4.6/debian/changelog	2014-01-06 23:02:36.000000000 +0000
@@ -1,3 +1,10 @@
+imlib2 (1.4.6-1fix1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Ensure "imlib2-config --libs" provides a valid result
+
+ --  <woo...@linaro.org>  Mon, 06 Jan 2014 23:01:04 +0000
+
 imlib2 (1.4.6-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru imlib2-1.4.6/debian/patches/03_fix-imlib-config-libraries.patch imlib2-1.4.6/debian/patches/03_fix-imlib-config-libraries.patch
--- imlib2-1.4.6/debian/patches/03_fix-imlib-config-libraries.patch	1970-01-01 00:00:00.000000000 +0000
+++ imlib2-1.4.6/debian/patches/03_fix-imlib-config-libraries.patch	2014-01-06 23:00:43.000000000 +0000
@@ -0,0 +1,22 @@
+Description: Provide valid library flags in imlib2-config script
+ Nothing in the build substitutes @my_libs@, so having it here just produces an invalid response to
+ /usr/bin/imlib2-config --libs.
+ If there is a good reason for this to be here then it needs to be substituted somewhere.
+Author: Wookey <woo...@debian.org>
+Last-Update: 2014-01-06
+
+
+
+Index: imlib2-1.4.6/imlib2-config.in
+===================================================================
+--- imlib2-1.4.6.orig/imlib2-config.in	2014-01-06 22:54:29.980000000 +0000
++++ imlib2-1.4.6/imlib2-config.in	2014-01-06 22:56:07.480000000 +0000
+@@ -46,7 +46,7 @@
+       ;;
+     --libs)
+       libdirs=-L@libdir@
+-      echo $libdirs -lImlib2 @my_libs@
++      echo $libdirs -lImlib2
+       ;;
+     *)
+       echo "${usage}" 1>&2
diff -Nru imlib2-1.4.6/debian/patches/series imlib2-1.4.6/debian/patches/series
--- imlib2-1.4.6/debian/patches/series	2013-12-27 11:35:17.000000000 +0000
+++ imlib2-1.4.6/debian/patches/series	2014-01-06 22:55:28.000000000 +0000
@@ -1,2 +1,3 @@
 01_removed-data-dir.patch
 02_fix-gif-with-no-cmap.patch
+03_fix-imlib-config-libraries.patch

Reply via email to