Hi Raphaël, On Tue, Dec 31, 2013 at 10:30:25AM +0100, Raphael Hertzog wrote: > Hi, > > On Fri, 09 Nov 2012, Raphael Hertzog wrote: > > On Thu, 08 Nov 2012, Guido Günther wrote: > > > So you're suggesting to not run clean by default? Or only when using > > > --export-dir? > > > > I'm suggesting that when --export-dir is present, then git-buildpackage > > should not call debian/rules clean in the git repository. > > > > When --export-dir is not present, it's ok since dpkg-buildpackage would > > call it anyway a bit later. And it allows you to distinguish between an > > unclean tree due to changes/bugs from an unclean tree due to a former > > build, so it's certainly ok to keep it. > > Ping, could we have the bug fixed ? It annoys the hell out of me every > time that I stumble on a upstream package whose "make clean" is broken > and where I add the required patch but since the git repository doesn't > have the patch applied, the build fails and I have to work around this > annoying behaviour of git-buildpackage. > > I have now started using debian/gbp.conf with cleaner = /bin/true as > work-around but it's a poor work-around IMO and I'd rather see the bug > fixed.
I'm a bit reluctant to make running the cleaner dependent on whether we use export-dir or not. However since I think there's little use for the cleaner itself nowadays I wonder if it might make more sense to use /bin/true as default for the cleaner (which I'm doing since ages). What do you think? Cheers, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
