Hi Luke,

I am looking into the changes that you and Jason provided, but I have a
serious issue with your proposed debian/copyright file (that IIUC is
already in Ubuntu, right?). There is no need to provide a new debdiff,
but I like your response, before I decide what I will do.

Biggest issue: you claimed sole copyright on all files in debian/ which
is completely not true.

Second issue: you put the GPL license on all files in debian/ without
proof that you even consulted the current maintainer or Jason.
Furthermore, it is not common to choose a different license than
upstream for the packaging. E.g. patches would be impossible to ship
upstream in this case. Therefore I think it should be the same as
upstream, as Shane and Jason didn't make a statement about that. Of
course you are free to put your work under GPL, but that just means I
will not use it, as I find it too unpractical in *this* case.

Third issue: you forgot that the current upstream maintainer also has
copyright on the source of dotconf.

Much lesser addition issue: I don't agree with the way you implemented
the get-orig-source target. Debian prefers to have the exact same tar
ball as released by upstream. This is obtainable at the following URL:
https://github.com/williamh/dotconf/releases. So I propose the attached
watch file instead of your target (and maybe call uscan in the
get-orig-source, but that is not much gain then). Furthermore:
1) Running autoreconf doesn't help, as you want to do this during build
time. It increases the tar ball drastically and because it is running an
unversioned version of autoreconf might even result in a different
orig.tar, which is exactly not what you want to achieve.
2) If you use a throw-away directory, use mktmp to create a proper
temporary directory.

@all: apparently upstream changed the soname, so this updates needs a
transition as well. This means that I need to do some more checking (all
reverse build dependencies) and that we need permission from the release
managers. Also the new package needs to go through NEW so it might take
some time there.

Paul
version=3
opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/dotconf-$1\.tar\.gz/ \
  https://github.com/williamh/dotconf/tags .*/v?(\d\S*)\.tar\.gz

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to