On Dec 12, 2013, at 05:34 PM, Arnaud Fontaine wrote:

>I must admit that I don't have so much time to maintain this package
>lately, so thank you very much for working on this, it's greatly
>appreciated.

You're welcome!  And thank you for all your previous work on the package.

>Sorry if that's a stupid question but I have not followed the
>development of pybuild, so the reason behind switching to pybuild is
>that it's much simpler (and thus debian/rules much shorter) for packages
>supporting Python 2 and 3 compared to cdbs and dh_python*, right?

Yes, especially when supporting both Python versions.  For setup-based
packages, it (usually) makes life so much easier. :)

>> +  [ Barry Warsaw ]
>> +  * Team upload.
>> +    - Closes: #731280
>> +    - Closes: #713747
>> +    - Closes: #673935
>
>Could you please close each bugs on its corresponding changelog entry as
>it's easier to understand?

Will do.

>> Index: debian/rules
>> ===================================================================
>> [...]
>>
>> -## SVN snapshot (changelog entry with a version: a.b.c~svnREVISION-d)
>> -## Get the source  from the SVN upstream repository,  then generate the
>> -## documentation (which is  in the release tarballs but  not in the SVN
>> -## repository and requires  python-docutils and python-epydoc packages)
>> -## and finally create the tarball
>> -#SVN_URL := https://svn.edgewall.org/repos/genshi/trunk
>> -#SVN_REVISION := $(shell echo $(DEB_UPSTREAM_VERSION)|sed 
>> 's/.*~svn\([0-9]*\)/\1/')
>> -#SVN_DEB_TARBALL_DIR := 
>> $(CURDIR)/debian/$(DEB_SOURCE_PACKAGE)-$(DEB_UPSTREAM_VERSION)
>> -#SVN_DEB_TARBALL :=  
>> $(CURDIR)/../$(DEB_SOURCE_PACKAGE)_$(DEB_UPSTREAM_VERSION).orig.tar.gz
>> -#
>> -## Adapted to CDBS and Genshi from:
>> -##  http://wiki.debian.org/SandroTosi/Svn_get-orig-source
>> -#get-orig-source:
>> -#   -rm -rf $(SVN_DEB_TARBALL_DIR) $(SVN_DEB_TARBALL)
>> -#
>> -#   svn export -r $(SVN_REVISION) $(SVN_URL) $(SVN_DEB_TARBALL_DIR)
>> -#
>> -#   ( cd $(SVN_DEB_TARBALL_DIR) && python setup.py build_doc )
>> -#
>> -#   # Get rid of byte-compile files created when building the
>> -#   # documentation
>> -#   find $(SVN_DEB_TARBALL_DIR) -name '*.pyc' -exec rm '{}' \;
>> -#
>> -#   GZIP='--best --no-name' tar czf $(SVN_DEB_TARBALL) -C 
>> $(SVN_DEB_TARBALL_DIR)/../ \
>> -#           $(DEB_SOURCE_PACKAGE)-$(DEB_UPSTREAM_VERSION)
>> -#
>> -#   -rm -rf $(SVN_DEB_TARBALL_DIR)
>> -#
>> -#   echo "Created: $(SVN_DEB_TARBALL)"
>> -#
>> -#.PHONY: get-orig-source
>
>Any reason why get-orig-source has been removed?

These were all commented out so they weren't being used anyway, but I don't
think it's necessary either.  Let's just have a working watch file and let the
default actions do their thing.

Cheers,
-Barry

Attachment: signature.asc
Description: PGP signature

Reply via email to