Package: git-annex
Version: 4.20131106
Severity: grave
Tags: upstream
Justification: causes non-serious data loss

Hi.

I hope I'm not overreacting.

Consider the following situation, where :

1. a file is annexed, with git annex add.
2. make the file modifiable : git annex unlock
3. modify the contents of the file.
3. git annex lock the file

The lock command doesn't complain that the file was modified, and silently 
removes it to replace it by the link to the previous version.

File changes are lost :-(

It seems this is on purpose, reading the manpage :
  Use this to undo an unlock command if you don't want to modify the files, or 
have made modifications you want  to  dis‐
  card.

IMHO, this is really undesirable, as one should be warned/prompted that a 
commit is necessary, by default. Only with an explicit force option would lock 
ever erase pending changes (there's git reset for reverting changes, and having 
lock duplicate the behaviour is confusing for git users, IMHO). Lock should 
just be the inverse of unlock, i.e. no longer allowing modifications, but not 
*erasing* modifications, if it happens there were some.

Hope this makes sense.

Best regards,

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages git-annex depends on:
ii  curl            7.33.0-1
ii  git             1:1.8.4.3-1
ii  libc6           2.17-97
ii  libffi6         3.0.13-4
ii  libgmp10        2:5.1.2+dfsg-3
ii  libgnutls26     2.12.23-8
ii  libgsasl7       1.8.0-2
ii  libicu48        4.8.1.1-14
ii  libidn11        1.28-1
ii  libxml2         2.9.1+dfsg1-3
ii  libyaml-0-2     0.1.4-2
ii  openssh-client  1:6.4p1-1
ii  rsync           3.1.0-2
ii  wget            1.14-5
ii  zlib1g          1:1.2.8.dfsg-1

Versions of packages git-annex recommends:
ii  bind9-host         1:9.8.4.dfsg.P1-6+nmu3
ii  git-remote-gcrypt  0.20130908-5
ii  gnupg              1.4.15-1.1
ii  lsof               4.86+dfsg-1
ii  quvi               0.4.2-1
ii  ssh-askpass        1:1.2.4.1-9

Versions of packages git-annex suggests:
pn  bup          <none>
ii  graphviz     2.26.3-15+b1
ii  libnss-mdns  0.10-3.2

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to