> dcmtk package is trying to set CMAKE_BUILD_TYPE to Release instead of
> letting the user decide what best to use.
> It would be nice to have an option to override this default, as Debian
> requires specific compilation flags, which conflicts with what
> CMAKE_BUILD_TYPE:Release sets.

> I am attaching current patch.

Your patch removes a patch that was contributed only recently by Jean-
Christophe Fillion-Robin from Kitware (i.e. the publisher of CMake):

  
http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=1beff6732f65c4e364acbd7d4643a02ed02f82ee

Also, as far as I can see, the "IF(NOT CMAKE_BUILD_TYPE AND NOT 
CMAKE_CONFIGURATION_TYPES)" statement should make sure that the build type is 
only set if it was undefined.

Don't you agree?


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to