Dear Debian maintainer,

On Friday, October 11, 2013, I sent you a notification about the beginning of a 
review
action on debconf templates for fheroes2-pkg.

Then, I sent you a bug report with rewritten templates and announcing
the beginning of the second phase of this action: call for translation
updates.

Translators have been working hard and here is now the result of their efforts.

Please consider using it EVEN if you committed files to your
development tree as long as they were reported.

The attached tarball contains:

- debian/changelog with the list of changes
- debian/control with rewrites of packages' descriptions
- debian/<templates> with all the rewritten templates file(s)
- debian/po/*.po with all PO files (existing ones and new ones)

As said, please use *at least* the PO files as provided here,
preferrably over those sent by translators in their bug reports. All
of them have been checked and reformatted. In some cases, formatting
errors have been corrected.

The patch.rfr file contains a patch for the templates and control
file(s) alone.

Please note that this patch applies to the templates and control
file(s) of your package as of Friday, October 11, 2013. If your package was 
updated
in the meantime, I may have updated my reference copy....but I also
may have missed that. This is indeed why I suggested you do not
modified such files while the review process was running,
remember..:-)

It is now safe to upload a new package version with these changes.

Please notify me of your intents with regards to this. 

There is of course no hurry to update your package but feel free to
contact me in case you would need sponsoring or any other action to
fix this.



-- 


Attachment: patch.tar.gz
Description: Binary data

--- fheroes2-pkg.old/debian/templates   2013-10-06 08:22:44.592797348 +0200
+++ fheroes2-pkg/debian/templates       2013-11-03 08:56:39.122412941 +0100
@@ -1,34 +1,45 @@
+# These templates have been reviewed by the debian-l10n-english
+# team
+#
+# If modifications/additions/rewording are needed, please ask
+# debian-l10n-engl...@lists.debian.org for advice.
+#
+# Even minor modifications require translation updates and such
+# changes should be coordinated with translators and reviewers.
+
 Template: fheroes2-pkg/build
 Type: boolean
 Default: true
-_Description: Continue?
- This application is about to download, compile from source code and
- install "${PKGG}${VER}" as Debian package (source files will be
- downloaded from SourceForge).
+_Description: Proceed with downloading and compiling fheroes2?
+ The fheroes2 AI is non-free due to a not-for-sale restriction, and
+ some images may also be non-free.
+ .
+ The installation process is therefore about to download the source files
+ from SourceForge, compile them, and install the binary deb package
+ "${PKGG}${VER}".
  .
- fheroes2 AI is non-free due to not-for-sale restriction.
- Also some images may be non-free.
+ Please confirm whether you wish this to happen.
 
 Template: fheroes2-pkg/first-install
 Type: note
 _Description:
- This application automates download, compile from source code and
- install "${PKGG}${VER}" as Debian package (source files will be
- downloaded from SourceForge).
+ The fheroes2 AI is non-free due to a not-for-sale restriction, and
+ some images may also be non-free.
  .
- fheroes2 AI is non-free due to not-for-sale restriction.
- Also some images may be non-free.
+ The installation process is therefore about to download the source files
+ from SourceForge, compile them, and install the binary deb package
+ "${PKGG}${VER}".
  .
- Please remember to run `sudo dpkg-reconfigure ${PKGI}`
+ Please remember to run "sudo dpkg-reconfigure ${PKGI}"
  to build and install guest package(s) for the first time.
 
 Template: fheroes2-pkg/title_b-i
 Type: title
-_Description: Build and install ${PKGG}${VER}.
+_Description: Build and install ${PKGG}${VER}
 
 Template: fheroes2-pkg/title_u
 Type: title
-_Description: Guest package(s) upgrade note.
+_Description: Upgrades available for guest package(s)
 
 Template: fheroes2-pkg/upgrade
 Type: note
@@ -36,39 +47,29 @@
  An update to guest package(s) [${PKGG_ALL}] version ${VER} is available
  but automatic upgrade is disabled.
  .
- Please remember to run `sudo dpkg-reconfigure ${PKGI}` to build and
- install guest package(s) or consider installing APT post-invoke hook.
+ Please remember to run "sudo dpkg-reconfigure ${PKGI}" to build and
+ install guest package(s) or consider installing the APT post-invoke hook.
 
 Template: fheroes2-pkg/post-invoke_hook-install
 Type: boolean
 Default: true
 _Description: Install APT post-invoke hook?
- APT post-invoke hook takes care of future automatic upgrades of guest
- package(s) on host package upgrade. After end of batch of APT
- operations hook will check whenever guest package(s) can be updated.
- If upgrade detected then hook will attempt to download/build and
- install package(s) using `dpkg -i` but only if `apt-get check` reported
- no errors.
- .
- At the moment there are no known problems associated with APT
- post-invoke hook which maintainer recommends to use with this package.
+ If activated, the APT post-invoke hook takes care of future automatic
+ upgrades of guest package(s) on host package upgrade. When an update
+ is available, the hook will attempt to download and build the package(s),
+ and (if "apt-get check" reports no errors) install them with "dpkg -i".
  .
- Alternatively guest package(s) can be built by manual invocation of
- `dpkg-reconfigure ${PKGI}`.
+ Alternatively, guest packages can be built by manual invocation of
+ "dpkg-reconfigure ${PKGI}".
 
 Template: fheroes2-pkg/post-invoke_hook-remove
 Type: boolean
 Default: false
 _Description: Remove APT post-invoke hook?
- APT post-invoke hook takes care of future automatic upgrades of guest
- package(s) on host package upgrade. After end of batch of APT
- operations hook will check whenever guest package(s) can be updated.
- If upgrade detected then hook will attempt to download/build and
- install package(s) using `dpkg -i` but only if `apt-get check` reported
- no errors.
- .
- At the moment there are no known problems associated with APT
- post-invoke hook which maintainer recommends to use with this package.
+ If activated, the APT post-invoke hook takes care of future automatic
+ upgrades of guest package(s) on host package upgrade. When an update
+ is available, the hook will attempt to download and build the package(s),
+ and (if "apt-get check" reports no errors) install them with "dpkg -i".
  .
- Alternatively guest package(s) can be built on manual invocation of
- `dpkg-reconfigure ${PKGI}`.
+ Alternatively, guest packages can be built by manual invocation of
+ "dpkg-reconfigure ${PKGI}".
--- fheroes2-pkg.old/debian/control     2013-10-06 08:22:44.592797348 +0200
+++ fheroes2-pkg/debian/control 2013-10-18 18:51:11.422377445 +0200
@@ -15,12 +15,12 @@
 Recommends: ${guest:Recommends} ,libcap2-bin
 Suggests: ${guest:Suggests}
          ,vrms
-Description: download, build and install fheroes2 package
- This package automatically download, build ${guest} from source code
- and install the resulting package.
+Description: fheroes2 package downloader and builder
+ This package automatically downloads the ${guest} source code,
+ builds it, and installs the resulting package.
  .
- Fheroes2 binaries are not distributable if built with AI due to
- licensing conflict between GPL-2 code and not-for-sale AI.
- Also Fheroes2 may contain some non-free images.
+ Fheroes2 binaries are not distributable if built with AI due to a
+ licensing conflict between GPL-2 code and the not-for-sale AI.
+ Fheroes2 may also contain some non-free images.
  .
  ${guest}: ${guest:Description}
--- fheroes2-pkg.old/debian/changelog   2013-10-06 08:22:44.592797348 +0200
+++ fheroes2-pkg/debian/changelog       2013-11-23 19:11:53.033252197 +0100
@@ -1,3 +1,20 @@
+fheroes2-pkg (0+svn20130304-2-2) UNRELEASED; urgency=low
+
+  * Debconf templates and debian/control reviewed by the debian-l10n-
+    english team as part of the Smith review project. Closes: #725467
+  * [Debconf translation updates]
+  * Russian (Yuri Kozlov).  Closes: #729108
+  * German (Chris Leick).  Closes: #729580
+  * French (Julien Patriarca).  Closes: #729967
+  * Polish (Michał Kułach).  Closes: #730062
+  * Portuguese (Américo Monteiro).  Closes: #730072
+  * Italian (Beatrice Torracca).  Closes: #730137
+  * Japanese (victory).  Closes: #730169
+  * Swedish (Martin Bagge / brother).  Closes: #730187
+  * Danish (Joe Hansen).  Closes: #730288
+
+ -- Christian Perrier <bubu...@debian.org>  Mon, 07 Oct 2013 07:10:16 +0200
+
 fheroes2-pkg (0+svn20130304-2-1) unstable; urgency=low
 
   * Upload to unstable.

Attachment: signature.asc
Description: Digital signature

Reply via email to