On Sun, Nov 17, 2013 at 1:31 PM, Pino Toscano wrote:
> Unfortunately, one of your patches introduces the same issues it is
> supposed to fix:
>
>> +@@ -65,9 +66,37 @@
>> + if (firstPage == 0)
>> + firstPage = 1;
>> + if (firstPage != lastPage && strstr(destFileName, "%d") == NULL) {
>> +- error(-1, "'%s' must contain '%%d' if more than one page should be
>> extracted", destFileName);
>> ++ error(-1, "'%s' must contain '%d' if more than one page should be
>> extracted", destFileName);
>> + return false;
>
> error() in poppler < 0.19 takes a printf-like format, so changing from
> %%d to %d will make printf expect an int, which is not passed as
> argument (and thus a we run into a new format string issue).
Thanks for spotting and correcting that.
> Oh, and btw:
>
>> +poppler (0.18.4-8+nmu1) unstable; urgency=high
>
> The NMU version is wrong, since it is not a native package; it should
> have been 0.18.4-8.1 instead, as also DevRef ยง5.11.2 says (but I see
> you spread this wrong versioning when NMUing, so hardly something you
> will change...)
Remember developers reference is a set of guidelines. The switch over
to +debXuY for stable uploads opened up more flexibility to use a
consistent versioning scheme for both native and non-native packages.
There was discussion on developers-reference about that over a year
ago that may be worth catching up on.
Best wishes,
Mike
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
