On Tue, Nov 12, 2013 at 5:58 PM, Petter Reinholdtsen <p...@hungry.com> wrote: > [Felipe Sateler] >> I believe i-ai-f should check if contrib or non-free are already >> enabled before adding the file. > > I agree, and I thought the code already present would only add it if > the wanted packages was missing from the available apt source. Any > idea why this code fail? This is the code in question: > > # Enable the non-free section if it is needed > if ! LC_ALL=C apt-cache show $binpkg 2>&1 | \ > grep -q 'E: No packages found' \
The test looks inverted (ie, the ! should go): % apt-cache policy firmware-realtek firmware-realtek: Installed: (none) Candidate: 0.40 Version table: 0.40 0 500 http://http.debian.net/debian/ sid/non-free amd64 Packages % if ! LC_ALL=C apt-cache show firmware-realtek 2>&1 | grep -q 'E: No packages found' ; then echo "erroneously adding" ; else echo "correctly not adding" ; fi erroneously adding -- Saludos, Felipe Sateler -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org