On Wed, Oct 30, 2013 at 02:38:39PM +0100, Tom Jampen wrote:
> +--- a/raddb/modules/detail 2013-10-30 11:55:01.600274413 +0100
> ++++ b/raddb/modules/detail 2013-10-30 12:07:34.703092048 +0100
> +@@ -31,7 +31,7 @@ detail {
> + # be ONE "listen" section reading detail files from a
> + # particular directory.
> + #
> +- detailfile =
> ${radacctdir}/%{%{Packet-Src-IP-Address}:-%{Packet-Src-IPv6-Address}}/detail-%Y%m%d
> ++ detailfile =
> ${radacctdir}/%{%{Packet-Src-IP-Address}:-%{Packet-Src-IPv6-Address}}/detail
So you'd be moving the decision of rotation from FR to logrotate - but I
wouldn't exactly be sure that FR is ready for it - does the detail module
necessarily close and reopen the files on every write, or will it keep
writing to the old file until you HUP it?
There have been some race condition bugs in the HUP handling in the past, so
this should really be verified beforehand.
Also, what about the people who are accustomed to the old defaults and have
their own scripts? It could easily break their setup, so we'd need a
NEWS.Debian warning at least.
> +@@ -43,7 +43,7 @@ server buffered-sql {
> + # The location where the detail file is located.
> + # This should be on local disk, and NOT on an NFS
> + # mounted location!
> +- filename = "${radacctdir}/detail-*"
> ++ filename = "${radacctdir}/detail.example.com/detail"
> +@@ -63,7 +63,7 @@ server copy-acct-to-home-server {
> + # one large file. File globbing also means that with
> + # a common naming scheme for detail files, then you can
> + # have many detail file writers, and only one reader.
> +- filename = ${radacctdir}/detail
> ++ filename = ${radacctdir}/detail.example.com/detail
> +@@ -40,7 +40,7 @@ server read-detail.example.com {
> + # the home server.
> + listen {
> + type = detail
> +- filename = "${radacctdir}/detail.example.com/detail-*:*"
> ++ filename = "${radacctdir}/detail.example.com/detail"
This is another beast altogether. What about race conditions here, that is,
what guarantees that the reader will be done reading all the data from the
detail file before it gets moved away by logrotate?
And why the new example hostname part in the first two, won't that also
break existing setups using the file?
--
2. That which causes joy or happiness.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
