Hi Manuel,, On Mon, Oct 28, 2013 at 10:30:50AM +0100, Manuel VIVES wrote: > Hi Guido [..snip..] > I agree with you for moving it into libvirt-bin, so I did it and I modified > the > libvirt-bin script in order to do this. > It is attached to the mail. > I also made a check for systemd, and if it's running, there is just a message > saying that you can not use this cgroup configuration with systemd and the > function exits.
Great! The systemd_running funciton seems to check for the wrong dir though ;) Moreover: shouldn't we better execute mount_cgroups when the daemon gets started (iff system_like_cgroups is set in /etc/default/libvirt-bin) and try to unmount it on daemon stop (we shouldn't fail then since there might be other cgroups running). Having them as extra targets is nice but wouln't work by itself if we want to do it automatically on system startup. Cheers, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
