Package: dds Version: 2.3.0+ddd105-1 Severity: important Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu trusty ubuntu-patch
In Ubuntu, the attached patch was applied to achieve the following: * makefile-gnu99: Use -std=gnu99 instead of -std=c99 to get popen() popen() isn't available in c99, but is in gnu90 (the compiler default), and gnu99 (which I've switched the package to here, to be as close to upstream's choice of c99 as possible, while still getting us popen). Without this patch, popen is implicitly delcared, leading then to an implicit pointer conversion, which is harmful on some platforms. For more on that, see: https://wiki.debian.org/ImplicitPointerConversions ... Adam -- System Information: Debian Release: wheezy/sid APT prefers trusty-updates APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500, 'trusty') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.11.0-12-generic (SMP w/4 CPU cores) Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru dds-2.3.0+ddd105/debian/changelog dds-2.3.0+ddd105/debian/changelog diff -Nru dds-2.3.0+ddd105/debian/patches/makefile-gnu99 dds-2.3.0+ddd105/debian/patches/makefile-gnu99 --- dds-2.3.0+ddd105/debian/patches/makefile-gnu99 1969-12-31 17:00:00.000000000 -0700 +++ dds-2.3.0+ddd105/debian/patches/makefile-gnu99 2013-10-26 10:33:19.000000000 -0600 @@ -0,0 +1,11 @@ +Description: Use -std=gnu99 instead of -std=c99 to get popen() +Author: Adam Conrad <adcon...@ubuntu.com> + +--- dds-2.3.0+ddd105.orig/Makefile ++++ dds-2.3.0+ddd105/Makefile +@@ -1,4 +1,4 @@ +-CFLAGS=-g -Wall -O2 -std=c99 -fopenmp ++CFLAGS=-g -Wall -O2 -std=gnu99 -fopenmp + PREFIX=/usr/local + + all: libdds.a python diff -Nru dds-2.3.0+ddd105/debian/patches/series dds-2.3.0+ddd105/debian/patches/series --- dds-2.3.0+ddd105/debian/patches/series 2013-09-15 14:39:11.000000000 -0600 +++ dds-2.3.0+ddd105/debian/patches/series 2013-10-26 10:33:01.000000000 -0600 @@ -19,3 +19,4 @@ ddd-fix-testsuite ddd-initstart ddd-openmp +makefile-gnu99
