Bug#332476: bug in modules/demux/ty.c

[miguel2i]

Package: vlc
Version: 0.8.1.svn20050314-1

Hello,

I have the same problem when vlc play filename without dot (like "udp://" 
"dvb://" "My movie")

To fix temporary the problem, Christian, you can delete the file 
/usr/lib/vlc/demux/libty_plugin.so (if you don't use this format)

The problem is in modules/demux/ty.c line 169 :

    {
        /* doesn't look like a TY file... */
        char *psz_ext = strrchr(p_demux->psz_path, '.');
        /* if they specified tydemux, or if the file ends in .ty we try anyway 
*/
        if (strcmp(p_demux->psz_demux, "tydemux") && strcasecmp(psz_ext, ".ty"))
            return VLC_EGENERIC;
        msg_Warn(p_demux, "this does not look like a TY file, continuing 
anyway...");
    }

segfault in strcasecmp when psz_path don't have dot

this is fix in vlc-0.8.2 with at line 169 :

        if( !p_demux->b_force &&
            (!psz_ext || strcasecmp(psz_ext, ".ty")) ) return VLC_EGENERIC;

we should fix with :

        if (strcmp(p_demux->psz_demux, "tydemux") && (!psz_ext 
||strcasecmp(psz_ext, ".ty")))
            return VLC_EGENERIC;

this may fix other bug like bug 303541 vlc: Segfault when trying to play DVD 
(ppc and amd64)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]