severity 337605 minor thanks On Sat, Nov 05, 2005 at 11:21:21AM +0100, Loic Minier wrote: > On Sat, Nov 05, 2005, Justin Pryzby wrote: > > removed `/root/.gstreamer-0.8/registry.xml' > > rmdir: removing directory, /root/.gstreamer-0.8 > > Unpacking replacement gstreamer0.8-misc ... > > I can't fathom a legitimate reason to remove anything under /root/, > > ever. I hope that I am I misinterprettign this message, but I just > > read the preinst script, and I am not: > > if [ -r "/root/.gstreamer-0.8/registry.xml" ]; then > > current="`cat "/root/.gstreamer-0.8/registry.xml"`" > > if [ "$orig" = "$current" ]; then > > rm -f -v "/root/.gstreamer-0.8/registry.xml" || true > > rmdir -v "/root/.gstreamer-0.8" || true > > fi > > fi > > Previously, gst-register-0.8 was called without the "GST_REGISTRY" > environment, and that caused some spurious files to be written to > /root/.gstreamer-0.8. Okay;
> I noticed this bug by cheer luck, and all system ever having a > gstreamer package installed (be it 0.6 or 0.8) had some spurious > directories. Hence, I decided to fix the problem and try removing as > much cruft as possible, so all packages where the fix appeared saw the > addition of code to detect whether the file was automatically > generated. Okay; why do you use a sh = test rather than diff followed by a check of $? ?. (diff Priority: required) > As you can see, the script is very cautious about removing a file with > the exact same contents as one generated by the package, and only > removes the directory if empty. Actually I didn't even read the conditional part last night. > If you think something else should have been done, please suggest what. I agree that this is pretty safe. Maybe leave the bug open until this snipped is removed from preinst? Which I guess is the first upload after etch release, correct? But is the problem actually fixed?? (Reading database ... 174462 files and directories currently installed.) Preparing to replace gstreamer0.8-misc 0.8.8-2 (using .../gstreamer0.8-misc_0.8.11-2_i386.deb) ... removed `/root/.gstreamer-0.8/registry.xml' rmdir: removing directory, /root/.gstreamer-0.8 Unpacking replacement gstreamer0.8-misc ... Setting up gstreamer0.8-misc (0.8.11-2) ... [EMAIL PROTECTED]:~$ ls /root/.g .gconf/ .gnome/ .gnome2_private/ .gconfd/ .gnome2/ .gstreamer/ [EMAIL PROTECTED]:~$ ls /root/.gstreamer/registry.xml [EMAIL PROTECTED]:~$ ls /root/.gstreamer/registry.xml /root/.gstreamer/registry.xml -- Clear skies, Justin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
