Hello James,

On May 30, 2013, at 17:00 , James Cloos wrote:

> The ip column should not be varchar or text.
> 
> It should be inet.
> 
> The proper fix is:
> 
>  alter table supermasters alter COLUMN ip type inet using ip::inet;
> 
> and change the sql which creates the table during install to use inet
> for that column.
> 
> That column is only supposed to hold ipv4 or ipv6 addresses, which is
> exactly what the inet type is for.
> 
> As an added bonus, inet stores the address as an integer, so it should
> take up less space than a text/varchar/char column.


We are happy to consider this change upstream - please file your request at 
https://github.com/PowerDNS/pdns/issues

Kind regards,
-- 
Peter van Dijk
Netherlabs Computer Consulting BV - http://www.netherlabs.nl/

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to