On Thu, Sep 26, 2013 at 07:40:41AM -0400, James McCoy wrote: > On Thu, Sep 26, 2013 at 12:42:59PM +0200, Jelmer Vernooij wrote: > > On Wed, Sep 25, 2013 at 11:43:23PM -0400, James McCoy wrote: > > > Package: mercurial-git > > > Version: 0.4.0-1 > > > Severity: important > > > Tags: upstream > > > Forwarded: https://github.com/schacon/hg-git/pull/267 > > > > > > dulwich made some API changes in 0.9.1 which break mercurial-git. > > > There's a patch in the forwarded URL. > > > > FWIW This should just cause a deprecation warning to be printed; it > > shouldn't break mercurial-git. If it does, can you please add a backtrace? > > mercurial-git implements its own SSHVendor[0], which doesn't happen to > derive from dulwich's. It just implements the interface. I'll amend my > suggested fix to have it also derive from dulwich's SSHVendor, since > that may make failures clearer in the future. > > [0]: https://github.com/schacon/hg-git/blob/master/hggit/_ssh.py > > Even if it had derived properly, the deprecation warning would only have > been emitted if it had already implemented a run_command method. There > was no reason for it to do so though since the code was written against > an earlier version of dulwich. Instead, NotImplementedError is raised.
This explanation isn't quite right. DeprecationWarnings get raised for code which uses dulwich and performs the connect_ssh call itself. mecurial-git implemented its own SSHVendor (to hook into Mercurial's ui), and dulwich tries to call a non-existent run_command on that object, which obviously raises an AttributeError since it doesn't have such a method. -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org> -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
