Control: tag -1 + confirmed Hi,
On Wed, Sep 25, 2013 at 10:38:54PM +0200, Bas Couwenberg wrote:
> >
> > + * Migrated to debhelper level 9 and policy bumped to 3.9.3.
> >
> > The former is definitely inappropriate for a stable update; the
> > latter
> > could be included but isn't particularly relevant.
>
> These debhelper and policy changes have been undone in the updated
> package.
>
> In the same commit in the Debian GIS repository --sourcedir=debian/tmp
> is dropped for dh_install which shouldn't effect the package as
> debhelper 7 and up already look in this directory.
>
> Should this dh_install change also be reverted none the less?
I'm prepared to close my eyes to it if you promise that you checked it has
no effect on the binary packages.
> > That would be:
> >
> > ++ if(strncmp(request->contenttype,
> > "application/x-www-form-urlencoded",
> > strlen("application/x-www-form-urlencoded")) == 0) {
> >
> > This will also match "application/x-www-form/urlencoded-badgers",
> > which
> > I assume wasn't intended. That may or may not be worse than the
> > original
> > bug though.
>
> The problem without the fix is that a Content-Type header such as
> "application/x-www-form-urlencoded; charset=UTF-8" is not matched
> causing the request to fail.
>
> While not a perfect fix for the problem, it does solve the issue.
> MapServer is able to handle POST requests by AJAX libraries.
>
> A better fix may be to test for either just
> "application/x-www-form-urlencoded" or followed by parameter(s), like:
>
> if((strcmp(request->contenttype, "application/x-www-form-urlencoded") == 0)
> || (strncmp(request->contenttype, "application/x-www-form-urlencoded;",
> strlen("application/x-www-form-urlencoded;")) == 0)) {
>
> Should I update the patch to use this, or is it acceptable as it is?
Hmm. There are swings and roundabouts when deviating from upstream; I think
this is close enough to be 'good enough'.
Please go ahead.
Thanks,
--
Jonathan Wiltshire j...@debian.org
Debian Developer http://people.debian.org/~jmw
4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
signature.asc
Description: Digital signature
