Control: found -1 1.19.8+dfsg-2
Control: severity -1 important
Justification: owncloud currently depends on the whole mediawiki just to
use this handful of classes. The alternative would be to ship
“convenient” embedded copies as done upstream, but this has
security implications.On Tue, Jun 25, 2013 at 05:56:55PM -0400, David Prévot wrote: > On Sun, Mar 24, 2013 at 10:33:35AM -0400, David Prévot wrote: > > > > So it would be nice to ship them in a standalone binary package, in > > order to be used by other packages (e.g. owncloud). > > Please find attached a proposed patch to fix this issue. I’m happy to > update it following your guidance if you’d prefer another approach. Please find attached an updated patch against the latest version of mediawiki, thanks in advance for including it into your next upload. Regards David
diff -Nru mediawiki-1.19.8+dfsg/debian/changelog mediawiki-1.19.8+dfsg/debian/changelog
--- mediawiki-1.19.8+dfsg/debian/changelog 2013-09-24 14:04:49.000000000 -0400
+++ mediawiki-1.19.8+dfsg/debian/changelog 2013-09-24 20:46:09.000000000 -0400
@@ -1,3 +1,9 @@
+mediawiki (1:1.19.8+dfsg-3) UNRELEASED; urgency=low
+
+ * Provide includes/libs in mediawiki-classes (Closes: #703837)
+
+ -- David Prévot <taf...@debian.org> Tue, 24 Sep 2013 20:45:55 -0400
+
mediawiki (1:1.19.8+dfsg-2) unstable; urgency=low
[ Thorsten Glaser ]
diff -Nru mediawiki-1.19.8+dfsg/debian/control mediawiki-1.19.8+dfsg/debian/control
--- mediawiki-1.19.8+dfsg/debian/control 2013-09-08 14:12:27.000000000 -0400
+++ mediawiki-1.19.8+dfsg/debian/control 2013-09-24 20:46:57.000000000 -0400
@@ -13,7 +13,7 @@
Package: mediawiki
Architecture: all
-Depends: apache2 | httpd, php5, php5-mysql | php5-pgsql | php5-sqlite | php5-mysqlnd, mime-support, libjs-jquery, libjs-jquery-tipsy, libjs-jquery-cookie, libjs-jquery-form, ${misc:Depends}
+Depends: apache2 | httpd, php5, php5-mysql | php5-pgsql | php5-sqlite | php5-mysqlnd, mime-support, libjs-jquery, libjs-jquery-tipsy, libjs-jquery-cookie, libjs-jquery-form, mediawiki-classes, ${misc:Depends}
Recommends: mysql-server | postgresql-contrib, php5-cli, python, php-wikidiff2, mediawiki-extensions-base
Suggests: imagemagick | php5-gd, mediawiki-extensions-math, memcached, clamav
Breaks: fusionforge-plugin-mediawiki (<< 5.2~rc1+1~),
@@ -30,6 +30,27 @@
MediaWiki is a wiki engine (a program for creating a collaboratively
edited website). It is designed to handle heavy websites containing
library-like document collections, and supports user uploads of
+ images/sounds, multilingual content, TOC autogeneration, ISBN links,
+ etc.
+ .
+ Moreover, it keeps track of changes, so users can receive
+ notifications, view diffs and revert edits. This system has many
+ other features and can easily be extended.
+
+Package: mediawiki-classes
+Architecture: all
+Depends: ${misc:Depends}
+Breaks: mediawiki (<< 1:1.19.8+dfsg-3~)
+Replaces: mediawiki (<< 1:1.19.8+dfsg-3~)
+Description: website engine for collaborative work - standalone classes
+ This package provides standalone classes from the remainder of the
+ MediaWiki codebase. They do not call on any other portions of MediaWiki
+ code, and can be used in portions of MediaWiki code, and can be used in
+ other projects without dependency issues.
+ .
+ MediaWiki is a wiki engine (a program for creating a collaboratively
+ edited website). It is designed to handle heavy websites containing
+ library-like document collections, and supports user uploads of
images/sounds, multilingual content, TOC autogeneration, ISBN links,
etc.
.
diff -Nru mediawiki-1.19.8+dfsg/debian/mediawiki-classes.install mediawiki-1.19.8+dfsg/debian/mediawiki-classes.install
--- mediawiki-1.19.8+dfsg/debian/mediawiki-classes.install 1969-12-31 20:00:00.000000000 -0400
+++ mediawiki-1.19.8+dfsg/debian/mediawiki-classes.install 2013-09-24 20:45:17.000000000 -0400
@@ -0,0 +1 @@
+includes/libs/*.php usr/share/mediawiki/includes/libs
diff -Nru mediawiki-1.19.8+dfsg/debian/rules mediawiki-1.19.8+dfsg/debian/rules
--- mediawiki-1.19.8+dfsg/debian/rules 2013-09-08 14:12:27.000000000 -0400
+++ mediawiki-1.19.8+dfsg/debian/rules 2013-09-24 20:45:17.000000000 -0400
@@ -42,6 +42,8 @@
# Put debian version for mediawiki version..
sed -e "s#$(DEB_UPSTREAM_VERSION)#$(DEB_NOEPOCH_VERSION)#" \
-i debian/mediawiki/usr/share/mediawiki/includes/DefaultSettings.php
+ # includes/libs is provided by mediawiki-classes
+ rm -rf debian/mediawiki/usr/share/mediawiki/includes/libs
override_dh_installdeb:
find debian/mediawiki -depth \( -name ".cvsignore" -o -name ".gitignore" -o -name ".arch-ids" \) -exec rm -rf {} \;
signature.asc
Description: Digital signature
