On Mon, Sep 16, 2013 at 06:53:21PM +0000, Zooko O'Whielacronx wrote: > Okay, now that I've reviewed > http://anonscm.debian.org/gitweb/?p=tahoe/tahoe.git;a=blob;f=debian/README.Debian;h=14ea2a7c1b38d41df36dd052c44cdf22603fd775;hb=87f7666c2c3a5059dc28ea95c336b9de7f08ae47 > and > http://anonscm.debian.org/gitweb/?p=tahoe/tahoe.git;a=blob;f=debian/tahoe-lafs.init;h=13b505fb4b2d4be959e3df7edef02a369a48fc7c;hb=8428876521454b5fd2b0719048caf909c0ab68ee > are there any more patches I should review?
No, there isn't. Thanks for the time you took to have a look at it. I rewrote it quite extensively to integrate the review you did, as well as one intrigeri did by private email. It does now use tahoe-lafs's own stop and restart commands as you pointed, and it had a lot of improvement on the shell writing style side. If you believe it is now in a better shape, I think it is ready to be merged into the package. I still have one or two minor packaging improvement to push. Once done, the package should be ready to be uploaded in the Debian archive. You can read the last initscript version there : http://anonscm.debian.org/gitweb/?p=tahoe/tahoe.git;a=blob;f=debian/tahoe-lafs.init;h=dda97b498f33330f47b3d284fd4228e8e0a1cd2b;hb=refs/heads/feature/sysvinit bert. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org