So, I'm not very happy at all with this patch, but want to discuss some of it.
Bits of it are fine, but the way that EmailFactory turned out is pretty terrible, in particular the hack in cleanup_uids. I'm wondering if things might become simpler if some of the logic is moved to the outside of EmailFactory, so that it is given a list of keys to import, the fingerprint of the signed key, the signed uid, a list of fingerprints to encrypt to, a from address and a to address. Currently some of the arguments are used for multiple things and I've made it even harder to follow with two extra... But in any case, my patch does work, I just tried it :) -- Philip Jägenstedt -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
