You're correct, this mfont code does not belong in the bold font
section of rxvt_change_font - this was the result of a faulty merge
with previous patches.

Planned for fix in 2.7.10-5.  Great catch.

On Wed, Sep 4, 2013 at 6:54 PM, Kevin Ryde <use...@zip.com.au> wrote:
> Package: rxvt
> Version: 1:2.7.10-4
> Severity: normal
> File: /usr/bin/rxvt-xterm
>
> If a bold font is specified then rxvt segfaults at startup.
>
>     rxvt-xterm -fb 9x15bold
>     =>
>     [ 8573.471347] rxvt[17335]: segfault at 48 ip 08050adb sp bfe62e80 error 
> 4 in rxvt-xterm[8048000+1e000]
>     Segmentation fault
>
> You can run this in the xvfb test server to be sure of a clean
> environment
>
>     xvfb-run rxvt -fb 9x15bold
>     => segv
>
> I suspect any setting for the bold font provokes the problem.  This
> "9x15bold" is an alias by xfonts-base package in its
> /etc/X11/fonts/misc/xfonts-base.alias
>
> It's possible this worked in the past since I had a setting for it in my
> .Xresources -- which now doesn't work :-)
>
>     Rxvt*boldFont: 9x15bold
>
>
> gdb suggests the offending code is main.c rxvt_change_font() at
>
>     if (recheckfonts) {
>         r->TermWin.boldFont = NULL;
>         if (r->TermWin.boldFont_loaded != NULL) {
>             fw = rxvt_get_fontwidest(r->TermWin.boldFont_loaded);
>             fh = r->TermWin.boldFont_loaded->ascent
>                  + r->TermWin.boldFont_loaded->descent;
>             if (r->TermWin.mfont->ascent > r->TermWin.fascent) {
>
> If you give a "-fb" bold font then boldFont_loaded is true.  But then
> r->TermWin.mfont is NULL and so the deref r->TermWin.mfont->ascent
> segfaults.
>
> I couldn't tell if mfont is supposed to be ready for use at that point.
> Its setup is actually the next thing done in rxvt_change_font(), no?
>
>
>
> -- System Information:
> Debian Release: jessie/sid
>   APT prefers unstable
>   APT policy: (990, 'unstable')
> Architecture: i386 (i686)
>
> Kernel: Linux 2.6.32-5-486
> Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
> Shell: /bin/sh linked to /bin/dash
>
> Versions of packages rxvt depends on:
> ii  libc6     2.17-92
> ii  libx11-6  2:1.6.1-1
> ii  libxpm4   1:3.5.10-1
>
> rxvt recommends no packages.
>
> rxvt suggests no packages.
>
> -- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to