Package: libkolab0
Version: 0.4.2-6
Severity: normal
Tags: patch
It seems libkolab tries to save to an invalid format when converting to a KDE
container. This results in destroyed kaddressbook entries.
This was fixed in
http://git.kolab.org/libkolab/commit/?id=fa19b0d21f3e064adbdff907f06cd15b2cb81d16
Please include it in an upload because enough addressbooks were already mangled
on my side and even more would be mangled when kolab is enabled in
kdepim-runtime in Debian.
A patch is attached.
--- System information. ---
Architecture: amd64
Kernel: Linux 3.10-2-amd64
Debian Release: jessie/sid
500 unstable www.deb-multimedia.org
500 unstable http.debian.net
500 unstable ftp.debian.org
500 testing http.debian.net
1 experimental www.deb-multimedia.org
1 experimental http.debian.net
--- Package information. ---
Depends (Version) | Installed
===================================-+-==============
libakonadi-notes4 (>= 4:4.9.3) | 4:4.10.5-1
libc6 (>= 2.14) |
libgcc1 (>= 1:4.1.1) |
libkabc4 (>= 4:4.3.4) |
libkcalcore4 (>= 4:4.5.86) |
libkcalutils4 (>= 4:4.5.86) |
libkdecore5 (>= 4:4.5.85) |
libkmime4 (>= 4:4.4.0) |
libkolabxml0 (>= 0.8.4) |
libkpimutils4 (>= 4:4.3.4) |
libqt4-xml (>= 4:4.5.3) |
libqtcore4 (>= 4:4.8.0) |
libqtgui4 (>= 4:4.5.3) |
libstdc++6 (>= 4.4.0) |
Package's Recommends field is empty.
Package's Suggests field is empty.
diff -Nru libkolab-0.4.2/debian/changelog libkolab-0.4.2/debian/changelog
--- libkolab-0.4.2/debian/changelog 2013-08-12 14:01:32.000000000 +0200
+++ libkolab-0.4.2/debian/changelog 2013-08-28 01:12:48.000000000 +0200
@@ -1,3 +1,9 @@
+libkolab (0.4.2-7~0.UNRELEASED) UNRELEASED; urgency=low
+
+ * Fix saving of pictures to kabc resources (Closes: #XXXXX)
+
+ -- Paul Klos <ko...@klos2day.nl> Wed, 28 Aug 2013 01:09:14 +0200
+
libkolab (0.4.2-6) unstable; urgency=low
* Disable rpath
diff -Nru libkolab-0.4.2/debian/patches/kabc-pictures.patch libkolab-0.4.2/debian/patches/kabc-pictures.patch
--- libkolab-0.4.2/debian/patches/kabc-pictures.patch 1970-01-01 01:00:00.000000000 +0100
+++ libkolab-0.4.2/debian/patches/kabc-pictures.patch 2013-08-28 01:13:19.000000000 +0200
@@ -0,0 +1,19 @@
+From fa19b0d21f3e064adbdff907f06cd15b2cb81d16 Mon Sep 17 00:00:00 2001
+From: Christian Mollekopf <mollek...@kolabsys.com>
+Date: Mon, 15 Jul 2013 09:32:21 +0000
+Subject: Don't set the picture type.
+
+Setting the type explicitly is not required and apparently breaks loading some images.
+---
+Index: libkolab-0.4.2/conversion/kabcconversion.cpp
+===================================================================
+--- libkolab-0.4.2.orig/conversion/kabcconversion.cpp 2013-08-28 01:13:12.086239454 +0200
++++ libkolab-0.4.2/conversion/kabcconversion.cpp 2013-08-28 01:13:12.074239454 +0200
+@@ -365,7 +365,6 @@
+ if (logo.isEmpty()) {
+ Error() << "failed to read picture";
+ }
+- logo.setType(fromStdString(mimetype));
+ return logo;
+ }
+
diff -Nru libkolab-0.4.2/debian/patches/series libkolab-0.4.2/debian/patches/series
--- libkolab-0.4.2/debian/patches/series 2013-08-12 14:01:32.000000000 +0200
+++ libkolab-0.4.2/debian/patches/series 2013-08-28 01:11:52.000000000 +0200
@@ -2,3 +2,4 @@
simpler_cmake_test.patch
libkolab-0.3.1-php-paths.patch
add-linker-flags.patch
+kabc-pictures.patch
