On Wed, Aug 21, 2013 at 11:08:14AM -0400, Joey Hess wrote:
> Chow Loong Jin wrote:
> > Attached.
> 
> So, this is with the current unpatched pristine-tar:
> 
> joey@gnu:~/tmp/x/foo>pristine-tar gendelta ~/foo.tar.gz ../delta
> joey@gnu:~/tmp/x/foo>pristine-tar  gentar ../delta ../foo.tar.gz 
> joey@gnu:~/tmp/x/foo>echo $?
> 0
> 
> Do you have a test case where the current one actually fails?
> AIUI, I knew that the code didn't always match up files in the directory
> with the tar manifest (though perhaps I didn't know about this reason
> for it to fail), and so I added fallback code. That fallback code might
> result in larger deltas, but it seems to work.

Yeah, try using that tarball with git import-orig --pristine-tar. The problem
really stems from trying to re-create all the empty directories that can't be
tracked by git.

> (I am glad to see that your patch keeps deltas produced with the old
> method working. I thought it might break them.)

-- 
Kind regards,
Loong Jin

Attachment: signature.asc
Description: Digital signature

Reply via email to